[csw-devel] SF.net SVN: gar:[3773] csw/mgar/pkg

[Maciej Bliziński]

Hi Roger,

A handful of comments below.

On Mon, Mar 16, 2009 at 3:07 AM,  <hson at users.sourceforge.net> wrote:
> Revision: 3773
>          http://gar.svn.sourceforge.net/gar/?rev=3773&view=rev
> Author:   hson
> Date:     2009-03-16 03:07:26 +0000 (Mon, 16 Mar 2009)
>
> Log Message:
> -----------
> facter: Initial commit
>
> Added Paths:
> -----------
>    csw/mgar/pkg/facter/
>    csw/mgar/pkg/facter/branches/
>    csw/mgar/pkg/facter/tags/
>    csw/mgar/pkg/facter/trunk/
>    csw/mgar/pkg/facter/trunk/Makefile
>    csw/mgar/pkg/facter/trunk/checksums
>    csw/mgar/pkg/facter/trunk/files/
>
>
> Property changes on: csw/mgar/pkg/facter/trunk
> ___________________________________________________________________
> Added: svn:ignore
>   + cookies
> download
> work
>
>
> Added: svn:externals
>   + gar https://gar.svn.sf.net/svnroot/gar/csw/mgar/gar/v2
>
>
> Added: csw/mgar/pkg/facter/trunk/Makefile
> ===================================================================
> --- csw/mgar/pkg/facter/trunk/Makefile                          (rev 0)
> +++ csw/mgar/pkg/facter/trunk/Makefile  2009-03-16 03:07:26 UTC (rev 3773)
> @@ -0,0 +1,38 @@
> +GARNAME = facter
> +GARVERSION = 1.5.4
> +CATEGORIES = apps
> +
> +DESCRIPTION =  a system fact gatherer
> +define BLURB
> +  Long description
> +endef

The blurb could be:

 define BLURB

-  Long description

+  http://reductivelabs.com/products/facter/

+

+  A cross-platform Ruby library for retrieving facts from operating systems.

+  Supports multiple resolution mechanisms, any of which can be restricted to

+  working only on certain operating systems or environments. Facter is

+  especially useful for retrieving things like operating system names, IP

+  addresses, MAC addresses, and SSH keys.

+

+  It is easy to extend Facter to include your own custom facts or to include

+  additional mechanisms for retrieving facts.

 endef



> +
> +MASTER_SITES = http://reductivelabs.com/downloads/facter/
> +DISTFILES  = $(GARNAME)-$(GARVERSION).tgz
> +
> +REQUIRED_PKGS = CSWruby
> +
> +# We define upstream file regex so we can be notifed of new upstream software release
> +UFILES_REGEX = $(GARNAME)-(\d+(?:\.\d+)*).tar.gz
> +
> +ARCHALL=1
> +
> +CONFIGURE_SCRIPTS = none
> +BUILD_SCRIPTS     = none
> +TEST_SCRIPTS      = none

Are these needed? You could write:

CONFIGURE_SCRIPTS =

BUILD_SCRIPTS     =

TEST_SCRIPTS      =


...and get rid of *-none targets.


> +install-facter:
> +       @ginstall -d $(DESTDIR)
> +       (cd $(WORKDIR)/$(DISTNAME); DESTDIR=$(DESTDIR) ruby install.rb)

This one line would look cleaner:

(cd $(WORKSRC); ./install.rb --destdir=$(DESTDIR))

(first ginstall isn't needed then)

Maciej