[csw-devel] [PATCH] Fix SPKG_DESC duplicate checking

Ben Walton bwalton at opencsw.org
Wed Aug 3 02:55:53 CEST 2011


Excerpts from Maciej Blizinski's message of Mon Aug 01 12:15:57 -0400 2011:
> Works around ticket #56.
> 
> http://sourceforge.net/apps/trac/gar/ticket/56
> 
> Previous attempt at fixing it:
> http://sourceforge.net/apps/trac/gar/changeset/11424

If we're shelling out, why not offload the whole thing to shell code
via an external script in gar/bin?

I wonder if checkpkg isn't a better place for this check though?
Separating package building from package verification makes sense to
me.  I know it's low hanging fruit to catch this directly in GAR but
it feels wrong to me.  If I want to build two packages with the same
description, I should be able to do so...and then override checkpkg
which enforces the policy.

What do others think about moving the check?

Thanks
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302



More information about the devel mailing list