[csw-devel] SF.net SVN: gar:[16568] csw/mgar/pkg

[Maciej (Matchek) Bliziński]

2011/12/19 <cgrzemba at users.sourceforge.net>
>
> Revision: 16568
>          http://gar.svn.sourceforge.net/gar/?rev=16568&view=rev
> Author:   cgrzemba
> Date:     2011-12-19 09:55:53 +0000 (Mon, 19 Dec 2011)
> Log Message:
> -----------
> svrcore/trunk: Mozilla Svrcore, first build
>
> Added Paths:
> -----------
>    csw/mgar/pkg/svrcore/
>    csw/mgar/pkg/svrcore/Makefile
>    csw/mgar/pkg/svrcore/branches/
>    csw/mgar/pkg/svrcore/tags/
>    csw/mgar/pkg/svrcore/trunk/
>    csw/mgar/pkg/svrcore/trunk/Makefile
>    csw/mgar/pkg/svrcore/trunk/checksums
>    csw/mgar/pkg/svrcore/trunk/files/
>
> Added: csw/mgar/pkg/svrcore/Makefile
> ===================================================================
> --- csw/mgar/pkg/svrcore/Makefile                               (rev 0)
> +++ csw/mgar/pkg/svrcore/Makefile       2011-12-19 09:55:53 UTC (rev 16568)
> @@ -0,0 +1,2 @@
> +%:
> +       $(MAKE) -C trunk $*
>
>
> Property changes on: csw/mgar/pkg/svrcore/trunk
> ___________________________________________________________________
> Added: svn:ignore
>   + cookies
> download
> work
>
>
> Added: svn:externals
>   + gar https://gar.svn.sourceforge.net/svnroot/gar/csw/mgar/gar/v2
>
>
> Added: csw/mgar/pkg/svrcore/trunk/Makefile
> ===================================================================
> --- csw/mgar/pkg/svrcore/trunk/Makefile                         (rev 0)
> +++ csw/mgar/pkg/svrcore/trunk/Makefile 2011-12-19 09:55:53 UTC (rev 16568)
> @@ -0,0 +1,72 @@
> +# $Id$
> +#
> +NAME = svrcore
> +MAJOR_VERSION = 4
> +MIN_VERSION = 0.4
> +VERSION = $(MAJOR_VERSION).$(MIN_VERSION)
> +GARTYPE = v2
> +CATEGORIES = lib
> +
> +DESCRIPTION = Mozilla LDAP SVR Core
> +define BLURB
> +  This is the Mozilla SVR Core needed by LDAP SDK
> +endef
> +
> +MASTER_SITES = http://ftp.mozilla.org/pub/directory/svrcore/releases/4.0.4/src/
> +DISTFILES  = $(NAME)-$(VERSION).tar.bz2
> +
> +# File name regex to get notifications about upstream software releases
> +# NOTE: Use this only if the automatic regex creation
> +#       does not work for your package
> +# UFILES_REGEX = $(NAME)-(\d+(?:\.\d+)*).tar.gz
> +
> +# If the url used to check for software update is different of MASTER_SITES, then
> +# uncomment the next line. Otherwise it is set by default to the value of MASTER_SITES
> +# UPSTREAM_MASTER_SITES =

You can remove the unused lines above.

> +PACKAGES += CSWlibsvrcore0
> +CATALOGNAME_CSWlibsvrcore0 = libsvrcore0
> +SPKG_DESC_CSWlibsvrcore0 += $(DESCRIPTION)
> +PKGFILES_CSWlibsvrcore0 = $(call pkgfiles_lib,libsvrcore.so.0)
> +RUNTIME_DEP_PKGS_CSWlibsvrcore0 += CSWlibnspr4
> +RUNTIME_DEP_PKGS_CSWlibsvrcore0 += CSWlibnss3
> +RUNTIME_DEP_PKGS_CSWlibsvrcore0 += CSWlibplc4
> +RUNTIME_DEP_PKGS_CSWlibsvrcore0 += CSWlibplds4
> +PACKAGING_PLATFORMS += solaris10-sparc
> +PACKAGING_PLATFORMS += solaris10-i386

You can move the PACKAGING_PLATFORMS lines closer to the top of the
file; they affect the whole recipe.

> +PACKAGES += CSWlibsvrcore0-dev
> +CATALOGNAME_CSWlibsvrcore0-dev = libsvrcore0_dev
> +SPKG_DESC_CSWlibsvrcore0-dev += $(DESCRIPTION), development files
> +PKGFILES_CSWlibsvrcore0-dev = $(PKGFILES_DEVEL)
> +PKGFILES_CSWlibsvrcore0-dev += /opt/csw/lib/libsvrcore.so
> +PKGFILES_CSWlibsvrcore0-dev += /opt/csw/lib/sparcv9/libsvrcore.so
> +ARCHALL_CSWgnutlsdevel = 1
> +
> +# Move the include files to include/nspr to prevent polluting the main
> +# header file namespace.
> +includedir = $(prefix)/include/nspr
> +
> +CONFIGURE_ARGS  = $(DIRPATHS)
> +CONFIGURE_ARGS_isa-sparcv9 = --enable-64bit
> +CONFIGURE_ARGS_isa-amd64 = --enable-64bit
> +CONFIGURE_ARGS += $(CONFIGURE_ARGS_$(MODULATION))
> +CONFIGURE_ARGS_OPT += --enable-optimize="-xO3"
> +CONFIGURE_ARGS_OPT += --disable-debug
> +CONFIGURE_ARGS_OPT += --enable-strip
> +CONFIGURE_ARGS_DBG += --enable-debug
> +CONFIGURE_ARGS_DBG += --disable-strip
> +CONFIGURE_ARGS_OPT += --with-nss-inc=/opt/csw/include/nss
> +CONFIGURE_ARGS_OPT += --with-nss-lib=/opt/csw/lib
> +CONFIGURE_ARGS_OPT += --with-nspr-inc=/opt/csw/include/nspr
> +CONFIGURE_ARGS_OPT += --with-nspr-lib=/opt/csw/lib

Two things: the library switches are probably not dependent on
GARFLAVOR; instead of using "/opt/csw/lib", use $(libdir), the same
goes for $(includedir).

> +CONFIGURE_ARGS += $(CONFIGURE_ARGS_$(GARFLAVOR))
> +
> +
> +RUNTIME_DEP_PKGS_CSWlibsvrcore0-dev += CSWlibsvrcore0

You can move that to the CSWlibsvrcore0-dev definition.

> +BUILD64 = 1
> +
> +include gar/category.mk

Looks good overall! Good job!