[csw-devel] Fwd: SF.net SVN: gar:[21385] csw/mgar/pkg/scummvm/trunk/Makefile

[Dagobert Michelsen]

Hi Laurent,

Anfang der weitergeleiteten E-Mail:

> Von: lblume at users.sourceforge.net
> Datum: 20. Juni 2013 20:47:29 MESZ
> An: devel at lists.opencsw.org
> Betreff: [csw-devel] SF.net SVN: gar:[21385] csw/mgar/pkg/scummvm/trunk/Makefile
> Antwort an: Broadcasts commit logs for build descriptions and GAR <devel at lists.opencsw.org>
> 
> Revision: 21385
>          http://gar.svn.sourceforge.net/gar/?rev=21385&view=rev
> Author:   lblume
> Date:     2013-06-20 18:47:26 +0000 (Thu, 20 Jun 2013)
> Log Message:
> -----------
> scummvm/trunk: Fix post-install files copy
> 
> Modified Paths:
> --------------
>    csw/mgar/pkg/scummvm/trunk/Makefile
> 
> Modified: csw/mgar/pkg/scummvm/trunk/Makefile
> ===================================================================
> --- csw/mgar/pkg/scummvm/trunk/Makefile	2013-06-20 18:05:15 UTC (rev 21384)
> +++ csw/mgar/pkg/scummvm/trunk/Makefile	2013-06-20 18:47:26 UTC (rev 21385)
> @@ -63,7 +63,10 @@
> PATH := /opt/csw/gnu:$(PATH)
> 
> post-install-modulated:
> -	ginstall -m 0644 $(WORKSRC)/README.solaris \
> +	ginstall -m 0644 $(FILEDIR)/README.solaris \

It is not a good idea to pull from FILEDIR, please use WORKDIR instead, because
stuff from DISTFILES is extracted there and it is really important all files are
listed in DISTFILES.

Best regards

  -- Dqgo

> 		$(DESTDIR)$(datadir)/doc/scummvm/
> -	ginstall -m 0644 $(WORKSRC)/scummvm.desktop \
> -		$(DESTDIR)$(datadir)/applications/scummvm/
> +	ginstall -m 755 -d $(DESTDIR)$(datadir)/applications
> +	ginstall -m 0644 $(FILEDIR)/scummvm.desktop \
> +		$(DESTDIR)$(datadir)/applications/
> +	@$(MAKECOOKIE)
> +
> 
> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
> 
> _______________________________________________
> devel mailing list
> devel at lists.opencsw.org
> https://lists.opencsw.org/mailman/listinfo/devel