[csw-maintainers] GAR sanity check for a double variable assignment in build descriptions

Dagobert Michelsen dam at opencsw.org
Thu Mar 19 10:35:05 CET 2009


Hi Sebastian,

Am 18.03.2009 um 22:43 schrieb Sebastian Kayser:
> Ben Walton wrote:
>> Excerpts from Sebastian Kayser's message of Wed Mar 18 14:40:45 -0400
>> 2009:
>>> The following excerpt demonstrates what i mean:
>>>
>>> PATCHFILES = patch-foo.diff
>>> PATCHFILES = patch-bar.diff
>>>
>>> yank&paste of the first line was used to produce the second and the
>>> missing += makes the first patch file "vanish" for the build.
>>
>> I don't think there is much you can do about this (although I'd love
>> to find out I'm wrong),
>
> Mhh, what about a perl/*sh script along the lines of checkpkg that  
> reads
> the build Makefile, searches all the = assignments and bails out or
> warns when hitting an assignment with a LHS that had been seen before?
>
> This script could be invoked as part of the GAR build process.

I find this too complicated. Make this error twice and search
a couple of hours and you know that once and for all :-)


Best regards

   -- Dago



More information about the maintainers mailing list