[csw-maintainers] help from mGar gods requested

[Mike Watters]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dagobert Michelsen wrote:
> Hi Mike,
> 
> Am 25.03.2009 um 16:21 schrieb Mike Watters:
>> inside of an ifeq ($(shell uname -p),i386)
>> I have tried using ISAEXEC_FILES = $(bindir)/file
>> I currently have it setup to be ISAEXEC_FILES_CSWpkgname =
>> /opt/csw/gcc4/bin/{file}
> 
> This should be ok. Doesn't it work the way you expected?
> 
> BTW, personally I disvavor the use of 'ifeq' to variable definition:
> 
>> ISAEXEC_FILES_CSWpkgname_i386 = /opt/csw/gcc4/bin/{file}
>> ISAEXEC_FILES_CSWpkgname = $(ISAEXEC_FILES_CSWpkgname_$(GARCH))
> 
> But this is more a matter of taste :-)
> 
> 
> Best regards
> 
>   -- Dago
> _______________________________________________
> maintainers mailing list
> maintainers at lists.opencsw.org
> https://lists.opencsw.org/mailman/listinfo/maintainers

I think both ifeq and .._$(GARCH) have their place
I think it is more readable for definitions like:
ifeq ($(shell uname -p),i386)
ifeq ($(shell uname -r),5.10)
    GARCOMPILER = SOS12
    SOS12_CC = /opt/studio/SOS12/SUNWspro/bin/cc
    BOOT_CFLAGS = -I/opt/csw/include -g -O2 -pipe
    BOOT_LDFLAGS  = -L/opt/csw/lib -R/opt/csw/lib
else
    GARCOMPILER = SOS11
    SOS11_CC = /opt/studio/SOS11/SUNWspro/bin/cc -xarch=386
    BOOT_CFLAGS = -I/opt/csw/include -m32 -march=i386 -g -O2 -pipe
    BOOT_LDFLAGS  = -L/opt/csw/lib -R/opt/csw/lib
endif
endif

and the ..._$(GARCH) for definitions like ISAEXEC_FILES_CSWpkg_i386
I made that change ;) and moved the definitions to the package_def.mk file

I made some tweaks and cleanups on the recipe and am rebuilding to validate them.
I will double check the pkgs again after rebuild and let you know if the links worked this time.
(after the build is done roughly 13hrs)

- --

Thanks,
Mike

"Any intelligent fool can make things bigger, more complex,
and more violent.  It takes a touch of genius -- and a lot of courage --
to move in the opposite direction."

* Albert Einstein 1879 - 1955
    US German-born Theoretical Physicist
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (SunOS)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAknKWNsACgkQLrhmsXMSLxczNwCgy8rBJ+nAL5/kXa16epLHxkIW
7wwAoKBc5QmktUSOc+k3UJTG+YSmqRhw
=Td4l
-----END PGP SIGNATURE-----