[csw-maintainers] Problems building CSWgar

[Dagobert Michelsen]

Hi Maciej,

Am 09.11.2009 um 18:14 schrieb Maciej (Matchek) Blizinski:
> When building CSWgar, I'm getting this error message:
>
> Transferring <CSWgar> package instance
> mkp: exec( gzip -9 -f /tmp/gar-7184,REV=2009.11.09-SunOS5.8-all- 
> CSW.pkg )
> mkp: exec( mv /tmp/gar-7184,REV=2009.11.09-SunOS5.8-all-CSW.pkg.gz
> /home/maciej/staging/build-2009-11-09 )
> mkp: exec( rm -rf /home/maciej/spool.5.8-i386/CSWgar )
> Examining /home/maciej/staging/build-2009-11-09/ 
> gar-7184,REV=2009.11.09-SunOS5.8-all-CSW.pkg.gz
> Looking for bad strings...
>        for badpath in /export/medusa /opt/build ; do
>        for badpath in /export/medusa /opt/build ; do
>
> ERROR: build-machine paths found in file
> /home/maciej/staging/build-2009-11-09/gar-7184,REV=2009.11.09- 
> SunOS5.8-all-CSW.pkg.gz
> ($badpath)
> gmake: *** [pkgcheck] Error 2
>
> Dago, I'm guessing you'll have an idea what's happening here.

Yes.

I. Why the built broke

When I changed to a single invocation of checkpkg I needed to change
the logic and evaluation of the ENABLE_CHECK variable. In the past there
was a check if it was "0" or not. I changed this to "TRUE" (meaning  
not-empty)
to conform to the other variables which I forgot to change hear. It  
shouldn't
harm to check anyway. This means that everywere where
   ENABLE_CHECK=0
was written there should be now
   ENABLE_CHECK=


II. The Makefile of the GAR package

As I was aware of the problem I chose to disable checking. This
is already done in the Makefile as it contains the lines

> # Because the bad pathes are in the bad pathes check we cannot check  
> ourselves
> ENABLE_CHECK = 0

This stopped working with the change I. and I took this out now with
your fix.


III. The check

The check for bad pathes must be reworked completely as the pathes  
were made
to fit the previous project. As OpenCSW has other pathes the existing  
ones
must be replaced.


Best regards

   -- Dago