[csw-maintainers] Review for the 389directoryserver project

[Dagobert Michelsen]

Hi Carsten,

Am 19.12.2011 um 13:17 schrieb Carsten Grzemba:
> please review my first part of the 389directoryserver project:
> 
> http://buildfarm.opencsw.org/experimental.html#389directoryserver

This should already be in $(PKGFILES_DEVEL):
  PKGFILES_CSWlibsvrcore0-dev += /opt/csw/lib/libsvrcore.so

This is probably a relict:
  ARCHALL_CSWgnutlsdevel = 1

I suggest changing this
  CONFIGURE_ARGS_isa-sparcv9 = --enable-64bit
  CONFIGURE_ARGS_isa-amd64 = --enable-64bit
  CONFIGURE_ARGS += $(CONFIGURE_ARGS_$(MODULATION))
to
  CONFIGURE_ARGS-64 = --enable-64bit
  CONFIGURE_ARGS += $(CONFIGURE_ARGS-$(MEMORYMODEL))

This looks like CFLAGS is not passed properly:
  CONFIGURE_ARGS_OPT += --enable-optimize="-xO3"
Maybe the contents should be $(CFLAGS) ?

I suggest moving this up after PKGFILES_*
  RUNTIME_DEP_PKGS_CSWlibsvrcore0-dev += CSWlibsvrcore0

Looks pretty good otherwise :-)


Best regards

  -- Dago

-- 
"You don't become great by trying to be great, you become great by wanting to do something,
and then doing it so hard that you become great in the process." - xkcd #896