[csw-maintainers] /testing Please help test updated CAS initsmf

Mark Phillips mark at probably.co.uk
Mon Mar 28 12:38:29 CEST 2011


On 28 Mar 2011, at 08:17, Maciej Bliziński wrote:

> 2011/3/27 Peter Bonivart <bonivart at opencsw.org>:
>> +    if [ "$SMF_STATE" = "enabled" ] || [ "$daemon" = "yes" -a
>> "$AUTOENABLE" != "no" -a "$AUTOENABLE" != "false" ]; then
> 
> This is a weird syntax, a combination of [ ] and -a.  I thought you
> could just use -o:
> 
>> +    if [ "$SMF_STATE" = "enabled" -o "$daemon" = "yes" -a
>> "$AUTOENABLE" != "no" -a "$AUTOENABLE" != "false" ]; then

I would've said -o too - easier to read, if nothing else.




More information about the maintainers mailing list