[bug-notifications] [php5 0003645]: postinstall scriopts in new php5_* packages have cruft on 1st and last line

[Mantis Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://www.opencsw.org/mantis/view.php?id=3645 
====================================================================== 
Reported By:                casterln
Assigned To:                mwatters
====================================================================== 
Project:                    php5
Issue ID:                   3645
Category:                   regular use
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     feedback
====================================================================== 
Date Submitted:             2009-04-23 00:34 CEST
Last Modified:              2009-04-23 02:26 CEST
====================================================================== 
Summary:                    postinstall scriopts in new php5_* packages have
cruft on 1st and last line
Description: 
The postinstall scripts all have a line like this at the beginning and end
of the scripts:

gmake[4]:: /home/mwatters/mgar/pkg/php5/trunk

THis generates a lot of noise on upgrade of each php5_*
====================================================================== 

---------------------------------------------------------------------- 
 (0006002) mwatters (manager) - 2009-04-23 01:34
 http://www.opencsw.org/mantis/view.php?id=3645#c6002 
---------------------------------------------------------------------- 
Can you give me a specific pacakge to look at.
I looked at a couple and didn't see anything out of sorts.

 

---------------------------------------------------------------------- 
 (0006003) casterln (reporter) - 2009-04-23 01:40
 http://www.opencsw.org/mantis/view.php?id=3645#c6003 
---------------------------------------------------------------------- 
Take a look at CSWphp5dba
or
CSWphp5calendar 

---------------------------------------------------------------------- 
 (0006004) casterln (reporter) - 2009-04-23 01:50
 http://www.opencsw.org/mantis/view.php?id=3645#c6004 
---------------------------------------------------------------------- 
I gunzipped and looked in

php5_calendar-5.2.9,REV=2009.04.18-SunOS5.8-sparc-CSW.pkg

and found the extraneous lines around line 69 or 79 and line 104 in the
pkg
file. 

---------------------------------------------------------------------- 
 (0006005) bwalton (reporter) - 2009-04-23 01:53
 http://www.opencsw.org/mantis/view.php?id=3645#c6005 
---------------------------------------------------------------------- 
This looks to be a glitch with the dynamic adm script feature.  I'm looking
into the GAR parts right now. 

---------------------------------------------------------------------- 
 (0006006) mwatters (manager) - 2009-04-23 02:26
 http://www.opencsw.org/mantis/view.php?id=3645#c6006 
---------------------------------------------------------------------- 
I don't have a box at hand to install.  
I tried to validate doing:
pkg-get -d php5_dba to download the gzipped package file
gzip -d php5_dba-5.2.9,REV=2009.04.21-SunOS5.8-sparc-CSW.pkg.gz
pkgtrans ./php5_dba-5.2.9,REV=2009.04.21-SunOS5.8-sparc-CSW.pkg . all
this creates CSWphp5dba directory.  
tomorrow I will attempt an install on my sparc s9 zone and sparc s10


$ cat CSWphp5dba/install/postinstall 
#!/bin/sh
PHP_INI=/opt/csw/php5/lib/php.ini
echo "[===> Running Post Install <===]"
echo "   ===> Enabling dba extension"
if grep 'CSW Extensions' ${PHP_INI} >/dev/null 2>&1; then
/bin/true
else
cat << _EOF_
******************************************************************************
* WARNING: Could not enable Extension "dba"
* You will need to enable it by hand as follows:
*
* open ${PHP_INI} in your favorite text editor
* Add the following line to the file, save, and restart your web server
* extension=dba.so
******************************************************************************
_EOF_
exit 0
fi
if grep 'extension=dba.so' ${PHP_INI} >/dev/null 2>&1; then
perl -i -plne 's|;extension=dba.so|extension=dba.so|' ${PHP_INI}
else
perl -i -pe 's|.*CSW Extensions|; CSW Extensions\nextension=dba.so|'
${PHP_INI}
fi
cat << _EOF_
******************************************************************************
* NOTICE: Successfully Enabled Extension "dba"
* in ${PHP_INI}
*
* You will need to restart your web server to finish the install
******************************************************************************
_EOF_
exit 0

$ 

Issue History 
Date Modified    Username       Field                    Change               
====================================================================== 
2009-04-23 00:34 casterln       New Issue                                    
2009-04-23 01:34 mwatters       Note Added: 0006002                          
2009-04-23 01:34 mwatters       Assigned To               => mwatters        
2009-04-23 01:34 mwatters       Status                   new => feedback     
2009-04-23 01:40 casterln       Note Added: 0006003                          
2009-04-23 01:50 casterln       Note Added: 0006004                          
2009-04-23 01:53 bwalton        Note Added: 0006005                          
2009-04-23 02:26 mwatters       Note Added: 0006006                          
======================================================================