[bug-notifications] [cswclassutils 0003785]: autoenable_specificdaemonname probably doesn't work

[Mantis Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://www.opencsw.org/mantis/view.php?id=3785 
====================================================================== 
Reported By:                yann
Assigned To:                bonivart
====================================================================== 
Project:                    cswclassutils
Issue ID:                   3785
Category:                   regular use
Reproducibility:            have not tried
Severity:                   minor
Priority:                   normal
Status:                     assigned
====================================================================== 
Date Submitted:             2009-07-28 20:37 CEST
Last Modified:              2009-08-10 17:16 CEST
====================================================================== 
Summary:                    autoenable_specificdaemonname probably doesn't work
Description: 
Hi,

Just had a look at i.cswinitsmf trying to solve a bug reported on my
package, and I noticed the code used to evaluate
autoenable_specificdaemonname is probably wrong.

The code is:

  if [ "$autoenable_$service" = "no" ]; then
    daemon=no
  elif [ "$autoenable_$service" = "yes" ]; then
    daemon=yes
  fi

but sh consider there are two variables $autoenable_ and $service. 
$autoenable_ has never been set so it is "", so for exemple for opencsw sh
will replace "$autoenable_$service" by "cswopenssh".

You could instead do:

eval autoenable_service="\$autoenable_$service"

and replace $autoenable_$service by $autoenable_service


====================================================================== 

---------------------------------------------------------------------- 
 (0006549) bonivart (manager) - 2009-08-10 17:16
 http://www.opencsw.org/mantis/view.php?id=3785#c6549 
---------------------------------------------------------------------- 
New beta out with the below fix:

@@ -76,9 +78,10 @@
   if [ "$autoenable_daemons" = "no" ]; then
     daemon=no
   fi
-  if [ "$autoenable_$service" = "no" ]; then
+  eval autoenable_service="\$autoenable_$service"
+  if [ "$autoenable_service" = "no" ]; then
     daemon=no
-  elif [ "$autoenable_$service" = "yes" ]; then
+  elif [ "$autoenable_service" = "yes" ]; then
     daemon=yes
   fi

http://mirror.opencsw.org/testing/cswclassutils-1.18,REV=2009.08.10-SunOS5.8-all-CSW.pkg.gz