[bug-notifications] [cswclassutils 0004075]: cswinitsmf should refuse to create an FMRI with a dot in the name

[Mantis Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
http://www.opencsw.org/mantis/view.php?id=4075 
====================================================================== 
Reported By:                maciej
Assigned To:                bonivart
====================================================================== 
Project:                    cswclassutils
Issue ID:                   4075
Category:                   other
Reproducibility:            always
Severity:                   minor
Priority:                   normal
Status:                     assigned
====================================================================== 
Date Submitted:             2009-12-10 09:34 CET
Last Modified:              2009-12-11 17:07 CET
====================================================================== 
Summary:                    cswinitsmf should refuse to create an FMRI with a
dot in the name
Description: 
08:25 <@automaciej> I just discovered that SMF FMRIs don't work if they
have dots in them.
08:25 <@automaciej> like, you can have cswpostgres_8_4, but can't have
cswpostgres_8.4
08:29 < lewellyn> yup
08:29 < lewellyn> it's documented somewhere, in fact.
08:29 <@automaciej> cswclassutils don't catch that
08:29 < lewellyn> that's why sun's services tend to be whatever23 or
whatever_23
08:30 < Dagobert> I guess it is because SMF is designed to be extended to
multi-host at some point in the future and . is a domain-sep. Same thing as
for auto*

====================================================================== 

---------------------------------------------------------------------- 
 (0007084) bonivart (manager) - 2009-12-11 17:07
 http://www.opencsw.org/mantis/view.php?id=4075#c7084 
---------------------------------------------------------------------- 
I think in general we shouldn't release faulty packages, if the user has
unknown local problems we can't do much about that but hopefulle handle it
with some grace but this is known to be in violation and shouldn't be
released.

We have decided to have all start scripts (used by cswinitsmf) in
/etc/opt/csw/init.d. Checkpkg could grep the script for an illegal FMRI. If
it's the default (commented out or not) "network" it's ok but if it's
something custom it shouldn't contain dots.

Ben was talking about remaking checkpkg (which is a total mess) into a
modular wrapper so many of us could contribute with separate tests that are
executed by the new checkpkg. It just needs a well defined interface to the
modules what to send as arguments and what to expect in return.