[bug-notifications] [cswutils 0004650]: checkpkg: wrong detection of package compression

[Mantis Bug Tracker]

A NOTE has been added to this issue. 
====================================================================== 
https://www.opencsw.org/mantis/view.php?id=4650 
====================================================================== 
Reported By:                pfelecan
Assigned To:                phil
====================================================================== 
Project:                    cswutils
Issue ID:                   4650
Category:                   regular use
Reproducibility:            always
Severity:                   block
Priority:                   high
Status:                     assigned
====================================================================== 
Date Submitted:             2010-12-31 16:40 CET
Last Modified:              2011-03-20 22:54 CET
====================================================================== 
Summary:                    checkpkg: wrong detection of package compression
Description: 
The detection of the compression of the package is wrong.

In the following construct:

file $f |sed 's/^.*://' |grep gzip >/dev/null

the sed regex is too greedy when gnulinks package is installed and file is
gfile; the output contains 2 :

The correct construct is:

file $f |sed 's/^[^:]*://' |grep gzip >/dev/null

IMHO the sed is not realy useful...
====================================================================== 

---------------------------------------------------------------------- 
 (0008937) phil (developer) - 2011-03-20 22:54
 https://www.opencsw.org/mantis/view.php?id=4650#c8937 
---------------------------------------------------------------------- 
Note to Peter:
The bigger problem, is that "gnu file" has drastically different output
from "file"... which is exactly why I personally dont put /opt/csw/gnu in
my normal path.

So, I think the best fix for this, is to ensure consistent output, by
forcing use of system file.
Which I have now done.  Fix in svn, Ben

btw, I dont tend to put things in for no reason. The sed is there, so that
it correctly determines file type for things that have "gzip" in their
name. such as the gzip package itself. or pkgzip. etc, etc.