[csw-devel] updated gar svn check

Ben Walton bwalton at opencsw.org
Wed Apr 15 22:09:28 CEST 2009


Excerpts from Dagobert Michelsen's message of Tue Apr 14 15:02:02 -0400 2009:

Hi Dago,

I dug into mkpackage and discovered that we are already supplying the
package filename (pkgname) via the csw_vars.gspec file that gets
pulled in.  So, I added a very small change to the dynamic gspec
generation code that supplies a %var that will supersede the %cvar if
the svn repo is in an uncommitted state.  This seems to work for
ENABLE_CHECK=0 and doesn't require an after-the-fact rename.

The downside to this approach is that if the maintainer hasn't
converted to dynamic gspec, then this modification won't be used.  I'm
ok with that personally.  What do you think?

[I added the UNCOMMITED at the end of the filename as replacing
REV=... was triggering a checkpkg rule.]

Thanks
-Ben
-- 
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302

GPG Key Id: 8E89F6D2; Key Server: pgp.mit.edu
Contact me to arrange for a CAcert assurance meeting.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: svn_uncommitted_pkgfile.patch
Type: application/octet-stream
Size: 632 bytes
Desc: not available
URL: <http://lists.opencsw.org/pipermail/devel/attachments/20090415/a75b5cdf/attachment-0002.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: <http://lists.opencsw.org/pipermail/devel/attachments/20090415/a75b5cdf/attachment-0002.asc>


More information about the devel mailing list