[csw-devel] updated gar svn check

[Dagobert Michelsen]

Hi Ben,

Am 16.04.2009 um 03:14 schrieb Ben Walton:
> Here's one more stab at this.  It addresses the points your raised
> with my last attempt.
>
> Thoughts?

Almost perfect ;-) SPKG_PKGFILE contains many %-expansions from  
environment
variables passed. We can set all these directly without the need of
deep-passing values into mkpackage:

+SPKG_PKGFILE = %{bitname}-%{SPKG_VERSION}%{SPKG_REVSTAMP}-% 
{SPKG_OSNAME}-%{arch}-CSW$(if $(findstring UNCOM,$(SPKG_PSTAMP)),- 
UNCOMMITTED).pkg

+SPKG_PKGFILE = %{bitname}-$(SPKG_VERSION)$(SPKG_REVSTAMP)-$ 
(SPKG_OSNAME)-%{arch}-CSW$(if $(findstring UNCOM,$(SPKG_PSTAMP)),- 
UNCOMMITTED).pkg

But then it is not possible any more to overwrite any of these during  
mkpackage
(if that is desirable of course...) I guess we just stick to your  
proposal.
We must stick to %{bitname} and %{arch} for static gspec anyway.

One more thing: SPKG_PSTAMP contains the value of $(_REVISION), and  
there are
more fault values: UNCOMMITTED, NOTVERSIONED (svn found, but not added  
to the
repository) and NOSVN (no subversion installed). This should do it
   $(filter $(SPKG_PSTAMP),UNCOMMITTED NOTVERSIONED NOSVN)


Best regards

   -- Dago