[csw-devel] SF.net SVN: gar:[2960] csw/mgar/pkg

[Trygve Laugstøl]

Dagobert Michelsen wrote:
> Hi William,
> 
> Am 01.02.2009 um 21:07 schrieb William Bonnet:
>>> The path should match the name of the jar file/project, and so should
>>> the short name. If we start adding heaps of Java stuff to GAR this  
>>> will
>>> collide pretty fast.
>> I'm not really sure to understand which path you are talking about.
>> SHORTNAME is a variable i have defined for my convenience, it is not
>> used by GAR. Please can you give me an example ? I have a few more  
>> to add...
> 
> Well, we have multiple namespaces:
> 
> (1) directoryname inside GAR
> (2) catalogname of package
> (3) packagename CSW<name>
> 
> The following statements should be valid:
> (a) For most packages the should be (2) == (3) with some exceptions  
> (e. g. Perl modules)

The Perl modules getting prefixed with "pm_" is fine, but there are
other discrepancies which I really don't like. But I guess that's life.

> (b) By design we have 1:n for (1):(2) and (1):(3), because one GAR  
> description may produce
>      several packages

True, but most builds create a single package (not counting _doc etc),
so it should be 1:1 in most cases.

> (c) There should be at least one package with (1) == (2)
> 
> For you there is
> 
> (1) collections
> (2) commons_collect and commons_collect_doc
> (3) CSWajccollect and CSWajccollectdoc
> 
> and hence neither (a) nor (b) nor (c) holds.
> 
> I propose to use
> 
> (1) GAR directory = ajccollect
> (2) catalogname ajccollect and ajccollect_doc
> (3) CSWajccollect and CSWajccollectdoc
> 
> Having a hard-to-remember name is imho worse than having pkgname !=  
> catalogname.

Yes, I have to agree with that. I just hope that it can get a better
name that "ajccollect". How long can a name be? "commons-collections" is
also one of the longer names, most are somewhat shorter.

> Phil, how about adding this to the standards?

+1

--
Trygve

> 
> Best regards
> 
>    -- Dago
> 
> 
>>>> Added: csw/mgar/pkg/collections/trunk/Makefile
>>>> ===================================================================
>>>> --- csw/mgar/pkg/collections/trunk/ 
>>>> Makefile	                        (rev 0)
>>>> +++ csw/mgar/pkg/collections/trunk/Makefile	2009-01-31 23:19:24  
>>>> UTC (rev 2960)
>>>> @@ -0,0 +1,56 @@
>>>> +SHORTNAME = collections
>>>> +GARVERSION = 3.2.1
>>>> +
>>>> +GARNAME = commons-$(SHORTNAME)
>>>> +CATEGORIES = java
>>>> ...
>>>>
>>>> +# Defines two packages, lib and doc
>>>> +DISTFILES += $(call admfiles,CSWajccollect,)
>>>> +DISTFILES += $(call admfiles,CSWajccollectdoc,)
>>>> +
> 
>>>> Added: csw/mgar/pkg/collections/trunk/files/CSWajccollect.gspec
>>>> ===================================================================
>>>> --- csw/mgar/pkg/collections/trunk/files/ 
>>>> CSWajccollect.gspec	                        (rev 0)
>>>> +++ csw/mgar/pkg/collections/trunk/files/CSWajccollect.gspec	 
>>>> 2009-01-31 23:19:24 UTC (rev 2960)
>>>> @@ -0,0 +1,5 @@
>>>> +%var            bitname commons_collect
>>>> +%var            pkgname CSWajccollect
>>>> +%var		arch	all
>>>> +%include        url file://%{PKGLIB}/csw_dyndepend.gspec
>>>> +%copyright      url file://%{WORKSRC_FIRSTMOD}/LICENSE.txt
>>>>
>>>> Added: csw/mgar/pkg/collections/trunk/files/CSWajccollectdoc.gspec
>>>> ===================================================================
>>>> --- csw/mgar/pkg/collections/trunk/files/ 
>>>> CSWajccollectdoc.gspec	                        (rev 0)
>>>> +++ csw/mgar/pkg/collections/trunk/files/CSWajccollectdoc.gspec	 
>>>> 2009-01-31 23:19:24 UTC (rev 2960)
>>>> @@ -0,0 +1,5 @@
>>>> +%var            bitname commons_collect_doc
>>>> +%var            pkgname CSWajccollectdoc
>>>> +%var		arch	all
>>>> +%include        url file://%{PKGLIB}/csw_dyndepend.gspec
>>>> +%copyright      url file://%{WORKSRC_FIRSTMOD}/LICENSE.txt
> _______________________________________________
> devel mailing list
> devel at lists.opencsw.org
> https://lists.opencsw.org/mailman/listinfo/devel