[csw-devel] SF.net SVN: gar:[11821] csw/mgar/gar/v2/lib/python/package_checks_test.py

wahwah at users.sourceforge.net wahwah at users.sourceforge.net
Mon Dec 6 23:53:05 CET 2010


Revision: 11821
          http://gar.svn.sourceforge.net/gar/?rev=11821&view=rev
Author:   wahwah
Date:     2010-12-06 22:53:04 +0000 (Mon, 06 Dec 2010)

Log Message:
-----------
checkpkg: Copying the test data structure

Turns out, there was a bug in my unit test.  I should have tested my
test first!

The problem was that one of the test was modifying a data structure that
other tests were using later on.

Modified Paths:
--------------
    csw/mgar/gar/v2/lib/python/package_checks_test.py

Modified: csw/mgar/gar/v2/lib/python/package_checks_test.py
===================================================================
--- csw/mgar/gar/v2/lib/python/package_checks_test.py	2010-12-06 22:33:25 UTC (rev 11820)
+++ csw/mgar/gar/v2/lib/python/package_checks_test.py	2010-12-06 22:53:04 UTC (rev 11821)
@@ -1448,7 +1448,7 @@
 class TestCheckDocDirLicense(CheckpkgUnitTestHelper, unittest.TestCase):
   FUNCTION_NAME = 'CheckDocDir'
   def CheckpkgTest(self):
-    self.pkg_data = neon_stats[0]
+    self.pkg_data = copy.deepcopy(neon_stats[0])
     self.pkg_data["pkgmap"].append({
       "class": "none", "type": "f", "line": "",
       "user": "root", "group": "bin", "mode": '0755',
@@ -1464,7 +1464,7 @@
   "A random file should not trigger the message; only license files."
   FUNCTION_NAME = 'CheckDocDir'
   def CheckpkgTest(self):
-    self.pkg_data = neon_stats[0]
+    self.pkg_data = copy.deepcopy(neon_stats[0])
     self.pkg_data["pkgmap"].append({
       "class": "none", "type": "f", "line": "",
       "user": "root", "group": "bin", "mode": '0755',


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.


More information about the devel mailing list