[csw-devel] SF.net SVN: gar:[10061] csw/mgar/gar/v2/lib/python

[wahwah at users.sourceforge.net]

Revision: 10061
          http://gar.svn.sourceforge.net/gar/?rev=10061&view=rev
Author:   wahwah
Date:     2010-06-01 11:54:53 +0000 (Tue, 01 Jun 2010)

Log Message:
-----------
mGAR v2: checkpkg, removing the check for init script location, there's a suspicion of the current policy leading to broken packages.

Modified Paths:
--------------
    csw/mgar/gar/v2/lib/python/package_checks.py
    csw/mgar/gar/v2/lib/python/package_checks_test.py

Modified: csw/mgar/gar/v2/lib/python/package_checks.py
===================================================================
--- csw/mgar/gar/v2/lib/python/package_checks.py	2010-06-01 00:34:37 UTC (rev 10060)
+++ csw/mgar/gar/v2/lib/python/package_checks.py	2010-06-01 11:54:53 UTC (rev 10061)
@@ -168,14 +168,18 @@
       error_mgr.ReportError(
           "init-file-missing-cswinitsmf-class",
           "%s class=%s" % (entry["path"], entry["class"]))
-    if "/etc/opt/csw/init.d" in entry["path"]:
-      messenger.Message("Init files should go into /opt/csw/etc/init.d, "
-                        "not /etc/opt/csw/init.d.")
-      error_mgr.ReportError(
-          "init-file-wrong-location",
-          entry["path"])
 
+    # This is not an error, in fact, putting files into
+    # /opt/csw/etc/init.d breaks packages.
+    #
+    # if "/etc/opt/csw/init.d" in entry["path"]:
+    #   messenger.Message("Init files should go into /opt/csw/etc/init.d, "
+    #                     "not /etc/opt/csw/init.d.")
+    #   error_mgr.ReportError(
+    #       "init-file-wrong-location",
+    #       entry["path"])
 
+
 def SetCheckLibraries(pkgs_data, error_mgr, logger, messenger):
   """Second version of the library checking code.
 

Modified: csw/mgar/gar/v2/lib/python/package_checks_test.py
===================================================================
--- csw/mgar/gar/v2/lib/python/package_checks_test.py	2010-06-01 00:34:37 UTC (rev 10060)
+++ csw/mgar/gar/v2/lib/python/package_checks_test.py	2010-06-01 11:54:53 UTC (rev 10061)
@@ -142,7 +142,8 @@
       "type": "f",
       "user": "root"
     })
-    self.error_mgr_mock.ReportError('init-file-wrong-location', '/etc/opt/csw/init.d/foo')
+    # This is not an error.
+    # self.error_mgr_mock.ReportError('init-file-wrong-location', '/etc/opt/csw/init.d/foo')
 
 
 class TestCatalognameLowercase_1(CheckpkgUnitTestHelper, unittest.TestCase):


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.