[csw-devel] proposed checkpkg change

Ben Walton bwalton at opencsw.org
Thu Apr 7 03:54:24 CEST 2011


Hi Maciej,

What do you think of the following change to checkpkg:

bwalton @ current9x : ~/opencsw/.buildsys/v2/lib/python
$ svn diff
Index: dependency_checks.py
===================================================================
--- dependency_checks.py        (revision 14086)
+++ dependency_checks.py        (working copy)
@@ -32,7 +32,7 @@
     (r".*\.pl$",   (u"CSWperl",)),
     (r".*\.pm$",   (u"CSWperl",)),
     (r".*\.py$",   (u"CSWpython",)),
-    (r".*\.rb$",   (u"CSWruby",)),
+    (r".*\.rb$",   (u"CSWruby", u"CSWruby18")),
     (r".*\.elc?$", (u"CSWemacscommon",)),
     (r"/opt/csw/apache2/", (u"CSWapache2",)),
 )


This allows a package containing .rb files to depend on CSWruby or
CSWruby18.  I could just do a straight s/CSWruby/CSWruby18/ and that
would be valid too.  What are your thoughts on this?  The only
downside I see is if we ever make CSWruby pull in 1.9 instead of 1.8
by default, people might end up with the wrong dep.  That's quite a
bit in the future though.

Thanks
-Ben
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302



More information about the devel mailing list