[csw-devel] proposed modification of i.cswusergroup

[Ben Walton]

Hi All,

The following patch to i.cswusergroup allows for a 9th field which is
a comma separated list of auxiliary groups (passed as -G to useradd)
in the cswusergroup file.  The validation of the field is done by
useradd although we could run it through a loop on getent group $g...

I've tested it (lightly) and it seems to work.  Does anyone else want
to give it a whirl and provide feedback before I commit it?

Thanks
-Ben

Index: files/CSWcswclassutils.i.cswusergroup
===================================================================
--- files/CSWcswclassutils.i.cswusergroup	(revision 14394)
+++ files/CSWcswclassutils.i.cswusergroup	(working copy)
@@ -5,8 +5,10 @@
 # $Id$
 #
 # Written by Peter Bonivart
+# Modified by Ben Walton
 #
 # 2009-02-10 First release
+# 2011-04-29 Add support for auxgroups
 #
 # Documentation: http://wiki.opencsw.org/cswclassutils-package
 #
@@ -171,6 +173,7 @@
   shell="$5"
   create="$6" 
   nopass="$7"
+  auxgroups="$8"
 
   if getent passwd $user > /dev/null; then
     echo User $user already exists
@@ -186,10 +189,11 @@
   [ -n "$dir" ] && dir="-d $dir"
   [ -n "$shell" ] && shell="-s $shell"
   [ -n "$create" ] && create="-m"
+  [ -n "$auxgroups" ] && auxgroups="-G $auxgroups"
 
-  debug_echo "/usr/sbin/useradd -g $uid $gcos $group $create $dir $shell $user"
+  debug_echo "/usr/sbin/useradd -g $uid $gcos $group $auxgroups $create $dir $shell $user"
   if /usr/sbin/useradd \
-       -u $uid $gcos $group $create $dir $shell $user > /dev/null
+       -u $uid $gcos $group $auxgroups $create $dir $shell $user > /dev/null
   then
     echo User $user has been added
   else
@@ -253,6 +257,7 @@
     shell=`echo $i | awk -F':' '{print $5}'`
     create=`echo $i | awk -F':' '{print $6}'`
     nopass=`echo $i | awk -F':' '{print $8}'`
+    auxgroups=`echo $i | awk -F':' '{print $9}'`
 
     if [ -n "$group" ]; then
       create_group $group
@@ -262,7 +267,7 @@
 
     if [ -n "$user" ]; then
       create_user \
-        "$user" "$group" "$gcos" "$dir" "$shell" "$create" "$nopass"
+        "$user" "$group" "$gcos" "$dir" "$shell" "$create" "$nopass" "$auxgroups"
     else
       echo No user to create
     fi
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302