[csw-devel] SF.net SVN: gar:[15454] csw/mgar/pkg/nagios/trunk/Makefile

[Maciej Bliziński]

Hi Juergen,

Here's a couple of comments below.

2011/8/28  <j_arndt at users.sourceforge.net>:
> Revision: 15454
>          http://gar.svn.sourceforge.net/gar/?rev=15454&view=rev
> Author:   j_arndt
> Date:     2011-08-28 19:19:20 +0000 (Sun, 28 Aug 2011)
> Log Message:
> -----------
> nagios: override of failures reported by chkpkg
>
> Modified Paths:
> --------------
>    csw/mgar/pkg/nagios/trunk/Makefile
>
> Modified: csw/mgar/pkg/nagios/trunk/Makefile
> ===================================================================
> --- csw/mgar/pkg/nagios/trunk/Makefile  2011-08-28 12:02:02 UTC (rev 15453)
> +++ csw/mgar/pkg/nagios/trunk/Makefile  2011-08-28 19:19:20 UTC (rev 15454)
> @@ -29,6 +29,7 @@
>  RUNTIME_DEP_PKGS_CSWnagios  = CSWapache2 CSWgd CSWglib2 CSWiconv CSWjpeg CSWlibtoolrt CSWggettextrt
>  RUNTIME_DEP_PKGS_CSWnagios += CSWosslrt CSWperl CSWpng CSWzlib CSWnagiosp CSWap2modphp5 CSWbdb
>  RUNTIME_DEP_PKGS_CSWnagios += CSWcswclassutils
> +RUNTIME_DEP_PKGS_CSWnagios += CSWlibgd2
>
>  LICENSE = LICENSE
>
> @@ -86,7 +87,7 @@
>
>  BUILD_ARGS = all
>
> -ENABLE_CHECK = 0
> +# ENABLE_CHECK = 0
>
>  TEST_TARGET = none
>
> @@ -98,6 +99,63 @@
>  #INSTALL_ARGS += install-config
>  INSTALL_ARGS += install-commandmode
>
> +#
> +# override chkpkg
> +# (in all html and cfg files the string /usr/local appears, which is uncritical.
> +#  the string appears in /opt/csw/nagios/bin/nagios and opt/csw/nagios/bin/p1.pl too, where it is a comment)
> +#
> +
> +CHECKPKG_OVERRIDES_CSWnagios += action-class-only-in-pkginfo|ugfiles
> +CHECKPKG_OVERRIDES_CSWnagios += action-class-only-in-pkginfo|cswmigrateconf

If there are no files using the ugfiles or cswmigrateconf classes, why
include them in the pkginfo?

> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/bin/nagios
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/bin/p1.pl
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/cgisecurity.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/monitoring-windows.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/volatileservices.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/faststartup.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/freshness.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/macros.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/config.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/upgrading.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/quickstart-opensuse.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/notifications.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/verifyconfig.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/redundancy.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/perfdata.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/configmain.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/monitoring-printers.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/quickstart-ubuntu.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/security.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/eventhandlers.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/startstop.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/cgiincludes.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/configcgi.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/distributed.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/int-tcpwrappers.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/cgiauth.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/objectdefinitions.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/monitoring-routers.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/clusters.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/nagiostats.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/quickstart-fedora.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/nagios/share/docs/configobject.html
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/etc/templates/CSWnagios/etc/opt/csw/nagios/nagios.cfg
> +CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content|/usr/local|root/opt/csw/etc/templates/CSWnagios/etc/opt/csw/nagios/cgi.cfg

You could replace this block with a single line:

CHECKPKG_OVERRIDES_CSWnagios += file-with-bad-content

> +#
> +# yes, we need this dependencies
> +#
> +

> +CHECKPKG_OVERRIDES_CSWnagios += obsolete-dependency|CSWcswclassutils

No package should depend on cswclassutils any more. Packages should
instead depend on the specific CAS package they need.

> +CHECKPKG_OVERRIDES_CSWnagios += surplus-dependency|CSWgd
> +CHECKPKG_OVERRIDES_CSWnagios += surplus-dependency|CSWglib2
> +CHECKPKG_OVERRIDES_CSWnagios += surplus-dependency|CSWnagiosp
> +CHECKPKG_OVERRIDES_CSWnagios += surplus-dependency|CSWlibtoolrt
> +CHECKPKG_OVERRIDES_CSWnagios += surplus-dependency|CSWap2modphp5
> +CHECKPKG_OVERRIDES_CSWnagios += surplus-dependency|CSWggettextrt
> +CHECKPKG_OVERRIDES_CSWnagios += surplus-dependency|CSWbdb
> +CHECKPKG_OVERRIDES_CSWnagios += surplus-dependency|CSWosslrt

If you know why the dependencies are needed, you could write that in
the comments. For example, CSWosslrt contains shared libraries, and
there are no binaries in the nagios packages that link against the ssl
libraries.  Perhaps there are binaries that use dlopen - if that's the
case, it makes sense to make a note of that in the build description.
The next person after you, not knowing why the dependencies are
needed, could simply remove them and break the package.

Maciej