[csw-devel] SF.net SVN: gar:[15227] csw/mgar/pkg

[Maciej Bliziński]

Em 28/07/2011 16:10, "Kester Habermann" <kester at opencsw.org> escreveu:
>
> Hi Maciej,
>
> On Thu, Jul 28, 2011 at 12:50:57PM +0100, Maciej Blizi??ski wrote:
> > Some comments on the code, below.
>
> Thanks for the comments. I hadn't even submitted this package yet.
>
> > > dsh: created package. libdshconfig: created package
> >
> > It's better for reviews and change tracking if you keep one commit per
> > package.
>
> Normally I'd do that. In this case they are coupled dsh needs libdshconfig
> and the author decided to distribute these as independent archived.

Fair enough, as long as you're aware of the issue.

> > > +# File name regex to get notifications about upstream software
releases
> > > +# NOTE: Use this only if the automatic regex creation
> > > +#       does not work for your package
> > > +# UFILES_REGEX = $(NAME)-(\d+(?:\.\d+)*).tar.gz
> >
> > You can remove the unused lines.
>
> I just left the file as it was created with "gmake newpkg-NAME". You're
right
> of course.
>
> > > +# for libintl_gettext, libintl_textdomain, libintl_bindtextdomain
> > > +LIBS += -lintl
> > > +export LIBS
> >
> > It's better to let gar handle this by setting EXTRA_LIBS (iirc).
Ignition
> > doesn't work in this case, you can make a note why the LIBS variable is
> > exported directly.
>
> I looked at
> EXTRA_LIB
>    A list of space separated, additional directories that are passed to
the compiler for linking purposes (via the -L and -R flags for Sun Studio).
>
> but this takes directories and doesn't work.

There was one that dealt with linker flags, Dago would know. Try to grep for
lintl, there must be an example out there.

The idea is that it's better if gar understands the intent.

> I also tried EXTRA_SOS_LD_OPTIONS, but this put the library in the middle
and
> not at the end which did not work.

Looks like a pretty demanding build.

> I don't know what you mean with "Ignition".

Sorry about that, it's the android autocompletion and me making a typo.

> The other tricky thing with building this package on the build system is
that
> the first package has to be built and installed before the second package
may
> be built.

Publishing to unstable makes it relatively easy. The step you can't do
yourself is installing the package on the unstable{9,10}{s,x} hosts.

> There is another issue, that there is a conflct with the package
CSWclusterit
> which contains a file of the same name (/opt/csw/bin/dsh) which is a
completely
> different program. I assume I will have to add that package as conflicting
> package.

In general, we try to avoid creating conflicting packages unless necessary.
In this case, CSWclusterit and your package could use alternatives to work
around the problem without creating incompatible packages.

> So this is considered work in progress. I submitted it, so it doesn't get
lost.

Excellent, it is a good practice. I prefer looking at incremental changes
rather than one giant change with everything.

I hope you don't mind me reading and commenting on the code as it flows in.

Maciej
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opencsw.org/pipermail/devel/attachments/20110728/10d092e1/attachment.html>