[csw-devel] proposed checkpkg test

[Ben Walton]

Hi All,

After noticing that bacula wanted to gzip manpages by default, I took
a look through the file database and noticed that several other
packages[1] provide gzipped manpages.  As solaris man can't handle
these, I'd consider it a bug in the packaging.  I propose this
addition to checkpkg:


$ svn diff
Index: package_checks.py
===================================================================
--- package_checks.py   (revision 14836)
+++ package_checks.py   (working copy)
@@ -220,6 +220,12 @@
       if re.search(perllocal_re, entry["path"]):
         error_mgr.ReportError("perllocal-pod-in-pkgmap",
	 entry["path"])
 
+def CheckGzippedManpages(pkg_data, error_mgr, logger, messenger):
+  gzipman_re = re.compile(r'share/man/man.*/.*\.gz$')
+  for entry in pkg_data["pkgmap"]:
+    if entry["path"]:
+      if re.search(gzipman_re, entry["path"]):
+        error_mgr.ReportError("gzipped-manpage-in-pkgmap",
entry["path"])
 
 def CheckMultipleDepends(pkg_data, error_mgr, logger, messenger):
   new_depends = set()

I tested it against CSWpuppet and I think it works as expected.
Maciej?

Thanks
-Ben

[1] CSWbochs, CSWpuppet, CSWconvmv
--
Ben Walton
Systems Programmer - CHASS
University of Toronto
C:416.407.5610 | W:416.978.4302