[csw-devel] SF.net SVN: gar:[16984] csw/mgar/pkg/git/trunk

bdwalton at users.sourceforge.net bdwalton at users.sourceforge.net
Fri Feb 3 05:02:49 CET 2012


Revision: 16984
          http://gar.svn.sourceforge.net/gar/?rev=16984&view=rev
Author:   bdwalton
Date:     2012-02-03 04:02:49 +0000 (Fri, 03 Feb 2012)
Log Message:
-----------
git/trunk: patch around a /bin/sh bug

Modified Paths:
--------------
    csw/mgar/pkg/git/trunk/Makefile

Added Paths:
-----------
    csw/mgar/pkg/git/trunk/files/0008-t0300-credentials-Word-around-a-solaris-bin-sh-bug.patch

Modified: csw/mgar/pkg/git/trunk/Makefile
===================================================================
--- csw/mgar/pkg/git/trunk/Makefile	2012-02-02 19:59:25 UTC (rev 16983)
+++ csw/mgar/pkg/git/trunk/Makefile	2012-02-03 04:02:49 UTC (rev 16984)
@@ -112,6 +112,7 @@
 PATCHFILES_isa-sparcv8 += 0005-Force-en_US.UTF-8-for-a-git-svn-test.patch
 PATCHFILES += 0006-Patch-out-a-few-usr-share-references.patch
 PATCHFILES += 0007-on-solaris-we-need-to-use-lintl-to-allow-the-new-i18.patch
+PATCHFILES += 0008-t0300-credentials-Word-around-a-solaris-bin-sh-bug.patch
 
 fdirs = $(bindir_install) $(mandir) $(libexecdir_install)
 define _git_files

Added: csw/mgar/pkg/git/trunk/files/0008-t0300-credentials-Word-around-a-solaris-bin-sh-bug.patch
===================================================================
--- csw/mgar/pkg/git/trunk/files/0008-t0300-credentials-Word-around-a-solaris-bin-sh-bug.patch	                        (rev 0)
+++ csw/mgar/pkg/git/trunk/files/0008-t0300-credentials-Word-around-a-solaris-bin-sh-bug.patch	2012-02-03 04:02:49 UTC (rev 16984)
@@ -0,0 +1,38 @@
+From a00449982532825591137ab59a25456e9b1d6d87 Mon Sep 17 00:00:00 2001
+From: Ben Walton <bwalton at opencsw.org>
+Date: Thu, 2 Feb 2012 15:40:36 +0100
+Subject: [PATCH] t0300-credentials: Word around a solaris /bin/sh bug
+
+Solaris' /bin/sh was making the IFS setting permanent instead of
+temporary when using it to slurp in credentials in the generated
+'dump' script of the 'setup helper scripts' test in t0300-credentials.
+
+To avoid this bug, capture the original IFS and force it to be reset
+after its use is no longer required.  For now, this is lighter weight
+than altering which shell these scripts use as their shebang.
+
+Signed-off-by: Ben Walton <bwalton at opencsw.org>
+---
+ t/t0300-credentials.sh |    2 ++
+ 1 files changed, 2 insertions(+), 0 deletions(-)
+
+diff --git a/t/t0300-credentials.sh b/t/t0300-credentials.sh
+index 885af8f..1be3fe2 100755
+--- a/t/t0300-credentials.sh
++++ b/t/t0300-credentials.sh
+@@ -8,10 +8,12 @@ test_expect_success 'setup helper scripts' '
+ 	cat >dump <<-\EOF &&
+ 	whoami=`echo $0 | sed s/.*git-credential-//`
+ 	echo >&2 "$whoami: $*"
++	OIFS=$IFS
+ 	while IFS== read key value; do
+ 		echo >&2 "$whoami: $key=$value"
+ 		eval "$key=$value"
+ 	done
++	IFS=$OIFS
+ 	EOF
+ 
+ 	cat >git-credential-useless <<-\EOF &&
+-- 
+1.7.8.3
+

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.



More information about the devel mailing list