[csw-devel] SF.net SVN: gar:[17002] csw/mgar/pkg/spamass-milter/trunk

[Juraj Lutter]

On 02/05/2012 03:21 PM, guengel at users.sourceforge.net wrote:
> Revision: 17002
>           http://gar.svn.sourceforge.net/gar/?rev=17002&view=rev
> Author:   guengel
> Date:     2012-02-05 14:21:24 +0000 (Sun, 05 Feb 2012)
> Log Message:
> -----------
> spamass-milter/trunk: Added patch to make it compile on solaris. Startup script and startup script config added. Minimalistic README.CSW and changelog.CSW added.
> +diff --git a/daemon.c b/daemon.c
> +index dd54571..d1245f6 100644
> +--- a/daemon.c
> ++++ b/daemon.c
> +@@ -39,7 +39,11 @@ static char sccsid[] = "@(#)daemon.c	8.1 (Berkeley) 6/4/93";
> + /* $Id: daemon.c,v 1.1 2003/10/21 21:40:32 dnelson Exp $ */
> + 
> + #include <fcntl.h>
> ++#ifndef __sun
> + #include <paths.h>
> ++#else
> ++#define _PATH_DEVNULL "/dev/null"
> ++#endif

Wouldn't it be better to use:

#ifndef _PATH_DEVULL
#define _PATH_DEVNULL "/dev/null"
#endif /* _PATH_DEVNULL */

rather than #ifndef __sun? In that case the patch can be accepted by
upstream as it seems less platform-dependent.

-- 
Juraj Lutter <wilbury at opencsw.org>