[csw-devel] SF.net SVN: gar:[18841] csw/mgar/pkg/lang-python/xpra/trunk/Makefile

[Maciej (Matchek) Bliziński]

2012/7/24  <cgrzemba at users.sourceforge.net>:
> Revision: 18841
>           http://gar.svn.sourceforge.net/gar/?rev=18841&view=rev
> Author:   cgrzemba
> Date:     2012-07-24 11:58:36 +0000 (Tue, 24 Jul 2012)
> Log Message:
> -----------
> lang-python/xpra/trunk: add runtime dependencies
>
> Modified Paths:
> --------------
>     csw/mgar/pkg/lang-python/xpra/trunk/Makefile
>
> Modified: csw/mgar/pkg/lang-python/xpra/trunk/Makefile
> ===================================================================
> --- csw/mgar/pkg/lang-python/xpra/trunk/Makefile        2012-07-24 11:12:28 UTC (rev 18840)
> +++ csw/mgar/pkg/lang-python/xpra/trunk/Makefile        2012-07-24 11:58:36 UTC (rev 18841)
> @@ -26,13 +26,33 @@
>  # uncomment the next line. Otherwise it is set by default to the value of MASTER_SITES
>  # UPSTREAM_MASTER_SITES =
>
> -ARCHALL = 1
> -BUILD_DEP_PKGS += CSWpy-gobject-dev CSWlibgtk2-dev CSWlibxtstdevel
> +BUILD_DEP_PKGS += CSWpy-gobject-dev CSWlibgtk2-dev CSWlibxtstdevel CSWpangodevel

I would generally keep one dependency per line. This way the diffs are
easier to review.

>  BUILD_DEP_PKGS += CSWlibxfixesdevel CSWlibxcompositedev CSWlibxdamagedevel CSWlibxrandrdevel
>  BUILD_DEP_PKGS += CSWx11recordproto CSWlibxextdevel CSWx11fixesproto CSWx11compositeproto
>  BUILD_DEP_PKGS += CSWx11damageproto CSWx11randrproto CSWcython CSWpython-dev
>  BUILD_DEP_PKGS += CSWlibx264-dev CSWffmpeg-dev
>
> +REINPLACE_USRSHARE += $(libdir)/python/site-packages/xpra/xposix/gui.py
> +REINPLACE_USRSHARE += $(libdir)/python/site-packages/xpra/platform/client_extras_base.py
> +REINPLACE_WHEN_USRSHARE = postinstall
> +REINPLACE_USRLOCAL += $(libdir)/python/site-packages/xpra/xposix/gui.py
> +REINPLACE_WHEN_USRLOCAL = postinstall
> +
> +PACKAGE += CSWxpra
> +
> +RUNTIME_DEP_PKGS_CSWxpra += CSWpython
> +RUNTIME_DEP_PKGS_CSWxpra += CSWlibswscale2 CSWlibavcodec54

Same goes here. If you keep one dep per line, it's easier to review.

> +RUNTIME_DEP_PKGS_CSWxpra += CSWlibx11

I think that we don't want to depend on this library.

> CSWlibgio2-0-0
> +RUNTIME_DEP_PKGS_CSWxpra += CSWpango CSWlibcairo2 CSWlibfreetype6
> +RUNTIME_DEP_PKGS_CSWxpra += CSWlibxdamage CSWlibxcomposite
> +RUNTIME_DEP_PKGS_CSWxpra += CSWlibx264-125
> +RUNTIME_DEP_PKGS_CSWxpra += CSWlibxfixes
> +
> +CHECKPKG_OVERRIDES_CSWxpra += pkginfo-description-not-starting-with-uppercase|screen|for|X
> +CHECKPKG_OVERRIDES_CSWxpra += pkgname-does-not-start-with-CSWpy-
> +CHECKPKG_OVERRIDES_CSWxpra += catalogname-does-not-start-with-py_
> +
> +
>  EXTRA_MERGE_EXCLUDE_FILES = .*\.pyo .*\.pyc
>
>  CONFIGURE_SCRIPTS =
>
> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
>
> _______________________________________________
> devel mailing list
> devel at lists.opencsw.org
> https://lists.opencsw.org/mailman/listinfo/devel