[csw-devel] SF.net SVN: gar:[21567] csw/mgar/pkg/git/trunk

Ben Walton bwalton at opencsw.org
Sun Jul 28 22:57:38 CEST 2013


On Sun, Jul 28, 2013 at 7:22 PM, Peter FELECAN <pfelecan at opencsw.org> wrote:
> bdwalton at users.sourceforge.net writes:
>
>> - test_expect_success '--stdin' '
>> -     expect_from_stdin <expected-default &&
>> -@@ -611,7 +611,7 @@ sed -e 's/^"//' -e 's/\\//' -e 's/"$//' stdin | \
>> - sed -e 's/^"//' -e 's/\\//' -e 's/"$//' expected-default | \
>> -     tr "\n" "\0" >expected-default0
>> - sed -e 's/  "/      /' -e 's/\\//' -e 's/"$//' expected-verbose | \
>> --    tr ":\t\n" "\0" >expected-verbose0
>> -+    perl -pne 's/[:\t\n]/\0/g' >expected-verbose0
>> -
>> - test_expect_success '--stdin from subdirectory' '
>> -     expect_from_stdin <expected-default &&
>
> It wouldn't be simpler to say gtr instead of tr or even more, without a
> patch, adding to the recipe:
>
>     PATH:=:/opt/csw/gnu:$(PATH)
>
> after
>
>     include gar/category.mk
>
> and adding a build dependency on CSWgnulinks and the package containing gtr?

Yes, it would, and that's how I used to build the package. At some
point I got into a discussion on the git list about how I avoided the
solaris userland and decided to fix the issues in git (thus making it
more portable) instead of ignoring them. At that point, I dropped
/opt/csw/gnu from the path and let the build system find all of the
clunky old junk instead. Every now and then I hit a small snag like
this but for the most part things actually run. In large part, this is
due to the project standards avoiding bashisms and non-POSIX
conventions (GNUisms) unless they slip through by mistake.

Thanks
-Ben


More information about the devel mailing list