[csw-devel] SF.net SVN: gar:[20987] csw/mgar/pkg

[Maciej Bliziński]

On Sat, May 04, 2013 at 01:52:48PM +0000, slowfranklin at users.sourceforge.net wrote:
> Added: csw/mgar/pkg/dconf/trunk/Makefile
> ===================================================================
> --- csw/mgar/pkg/dconf/trunk/Makefile	                        (rev 0)
> +++ csw/mgar/pkg/dconf/trunk/Makefile	2013-05-04 13:52:47 UTC (rev 20987)
> @@ -0,0 +1,59 @@
> +# $Id$
> +# TODO (release-critical prefixed with !, non release-critical with *)
> +#
> +NAME = dconf
> +VERSION = 0.5.1
> +GARTYPE = v2
> +
> +DESCRIPTION = low-level configuration system for glib
> +define BLURB
> +  dconf is a low-level configuration system. Its main purpose is to
> +  provide a backend to GSettings on platforms that dont already have
> +  configuration storage systems.
> +endef
> +
> +MASTER_SITES = $(GNOME_MIRROR)
> +DISTFILES  = $(NAME)-$(VERSION).tar.bz2

You can use DISTNAME instead of $(NAME)-$(VERSION).

Note to self: we should fix the template.

> +GARCOMPILER = GNU
> +
> +EXTRA_PKG_CONFIG_DIRS = $(prefix)/X11/lib

We should not be using /opt/csw/X11, we should be using system X11
instead.

> +EXTRA_INC = $(prefix)/include/gtk-2.0
> +EXTRA_INC += $(prefix)/include/cairo
> +EXTRA_INC += $(prefix)/include/pango-1.0
> +EXTRA_INC += $(prefix)/lib/gtk-2.0/include/
> +EXTRA_INC += $(prefix)/include/gdk-pixbuf-2.0/
> +EXTRA_INC += $(prefix)/include/atk-1.0/

This doesn't look right. Normally, you only have -I/opt/csw/include
(which is the default already) and source code refers to relative paths
underneath. What happens when you remove these lines?

> +BUILD_DEP_PKGS += CSWlibdbusdev
> +BUILD_DEP_PKGS += CSWpkgconfig
> +BUILD_DEP_PKGS += CSWglib2devel
> +BUILD_DEP_PKGS += CSWgtk2devel
> +
> +RUNTIME_DEP_PKGS += CSWlibgio2-0-0
> +RUNTIME_DEP_PKGS += CSWglib2
> +RUNTIME_DEP_PKGS += CSWlibdbus
> +
> +PACKAGES += CSWdconf
> +SPKG_DESC_CSWdconf = $(DESCRIPTION)
> +RUNTIME_DEP_PKGS_CSWdconf += CSWlibdconf0
> +
> +PACKAGES += CSWlibdconf0
> +SPKG_DESC_CSWlibdconf0 = $(DESCRIPTION), library
> +PKGFILES_CSWlibdconf0 += $(call pkgfiles_lib,libdconf.so)
> +
> +PACKAGES += CSWlibdconf-dev
> +SPKG_DESC_CSWlibdconf-dev = $(DESCRIPTION), development files
> +PKGFILES_CSWlibdconf-dev += $(PKGFILES_DEVEL)
> +PKGFILES_CSWlibdconf-dev += $(call baseisadirs,$(datadir),vala/vapi/dconf\.deps)
> +PKGFILES_CSWlibdconf-dev += $(call baseisadirs,$(datadir),vala/vapi/dconf\.vapi)
> +RUNTIME_DEP_PKGS_CSWlibdconf-dev += CSWlibdconf0
> +
> +PATCHFILES += 0001-Use-statvfs-for-checking-filesystem-type.patch
> +PATCHFILES += 0002-Remove-linker-flags-remove-c89-request.patch
> +PATCHFILES += 0003-Add-gio-includes.patch
> +
> +CONFIGURE_ARGS = $(DIRPATHS)
> +CONFIGURE_ARGS += CFLAGS="-std=c99 -D__EXTENSIONS__"

__EXTENSIONS__ is a flag meaningful for Solaris Studio, is it meaningful
for GCC at all? I would think it isn't.

Maciej
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.opencsw.org/pipermail/devel/attachments/20130504/3461bbf6/attachment.asc>