[csw-devel] SF.net SVN: gar:[21923] csw/mgar/gar/v2/lib/python/checkpkg_lib.py

[wahwah at users.sourceforge.net]

Revision: 21923
          http://gar.svn.sourceforge.net/gar/?rev=21923&view=rev
Author:   wahwah
Date:     2013-09-14 15:36:50 +0000 (Sat, 14 Sep 2013)
Log Message:
-----------
pkgdb: Cleanup.

Modified Paths:
--------------
    csw/mgar/gar/v2/lib/python/checkpkg_lib.py

Modified: csw/mgar/gar/v2/lib/python/checkpkg_lib.py
===================================================================
--- csw/mgar/gar/v2/lib/python/checkpkg_lib.py	2013-09-14 15:36:41 UTC (rev 21922)
+++ csw/mgar/gar/v2/lib/python/checkpkg_lib.py	2013-09-14 15:36:50 UTC (rev 21923)
@@ -1180,17 +1180,20 @@
                       sqo_srv4, osrel, arch, catrel)
       # Our srv4 is already part of that catalog.
       return
+    # SQL INSERT happens here.
     obj = m.Srv4FileInCatalog(
         arch=sqo_arch,
         osrel=sqo_osrel,
         catrel=sqo_catrel,
         srv4file=sqo_srv4,
         created_by=who)
+    # The package is now in the catalog.
 
   def RemoveSrv4(self, sqo_srv4, osrel, arch, catrel):
     sqo_osrel, sqo_arch, sqo_catrel = self.GetSqlobjectTriad(
         osrel, arch, catrel)
     try:
+      # There's a race condition in here. Maybe SQLObject allows to delete atomically?
       sqo_srv4_in_cat = m.Srv4FileInCatalog.select(
           sqlobject.AND(
             m.Srv4FileInCatalog.q.arch==sqo_arch,

This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.