[csw-maintainers] Building postgresql-8.4.1

[Philip Brown]

>(Dagobert writes)
> I had this problem myself some times but didn't recognize the cause
> properly:
>  grep filter-out */trunk/Makefile | grep CFLAGS
> I even used argument-reordering on compile invocation for flac to
> work around it which may have better be solved in the above way.
> Now that I have understood it I would propose to remove
> the "-I" from CFLAGS in GAR, but I am afraid that this may break
> existing Makefiles as they may rely on it. This is especially true
> for manual builds which pass CFLAGS explicitly without passing
> CPPFLAGS explicitly.
>
> What do the C-gurus say? James? Anybody?
>


In my opinion, it belongs in CPPFLAGS, if you are going to force defaults.
(and you should make sure to force our default as "first" :-)

package builds that break, will break. Although most shouldnt.
Ones that do, will have to be fixed when needed.