[csw-maintainers] 'checkpkg' checking multiple packages at once

[Dagobert Michelsen]

Hi Ben,

Am 06.09.2009 um 03:08 schrieb Ben Walton:
> I just commited the updated checkpkg to GAR.  It's the reference
> script in gar/bin/checkpkg now, although it's not used by GAR at this
> point.  The following modification would be required to force this
> version into play:
>
> --snip--
> Index: gar.pkg.mk
> ===================================================================
> --- gar.pkg.mk  (revision 6198)
> +++ gar.pkg.mk  (working copy)
> @@ -587,7 +587,7 @@
>
> pkgcheck-%:
>        @echo " ==> Checking compliance: $*"
> -       @( LC_ALL=C checkpkg $(SPKG_EXPORT)/`$(call _PKG_ENV,$1)
>        mkpackage -qs $(WORKDIR)/$*.gspec -D pkgfile`.gz ) || exit 2
> +       @( LC_ALL=C $(GARBIN)/checkpkg $(SPKG_EXPORT)/`$(call
>        _PKG_ENV,$1) mkpackage -qs $(WORKDIR)/$*.gspec -D pkgfile`.gz
>        ) || exit 2
>
> pkgcheck-p:
>        @$(foreach COOKIEFILE,$(PKGCHECK_TARGETS), test -e
>        $(COOKIEDIR)/$(COOKIEFILE) ;)
> --snip--
>
> This new version can handle libraries that are split out as well as
> inter-set dependencies.  I've tested with the packages created by the
> bind build (since none of them are on the build farm boxes) and it
> seems to behave properly.
>
> If you're happy with this, I can proceed to modifying GAR so that all
> packages are validated together which would leverage the new
> capabilities.


Cool!

Phil: I would include that into CSWcswutils, ok?
Ben: If the updated version gets into CSWcswutils there is no need for a
GAR-private checkpkg. CSWcswutils is already built with GAR and checkpkg
is tracked at
   <https://sourceforge.net/apps/trac/gar/browser/csw/mgar/pkg/cswutils/trunk/files/checkpkg 
 >


Best regards

   -- Dago