[csw-maintainers] addition to CSWcommon?

Philip Brown phil at bolthole.com
Fri Dec 31 22:03:22 CET 2010


On Fri, Dec 31, 2010 at 11:35 AM, Ben Walton <bwalton at opencsw.org> wrote:
> Excerpts from Maciej (Matchek) Blizinski's message of Wed Dec 29 20:50:46 -0500 2010:
>
>> +  # Create the base directory if not present.
>> +  # http://lists.opencsw.org/pipermail/maintainers/2010-December/013456.html
>> +  base_dir=`/usr/bin/dirname ${dest}`
>> +  if [ -r "${base_dir}" ]; then
>> +      :
>> +  else
>> +      mkdir -p "${base_dir}"
>> +  fi
>> +
>>    if [ "$smf" = "yes" ]; then
>>      # Copy the service script
>>      /usr/bin/cp $src $dest || exit 2
>
> This looks ok as long as the rest of the script isn't taking the
> install root into account.  If it is, then this could potentially
> break in a jumpstart.  I'm not sure that this CAS is suited to a
> jumpstart install anyway though...?


It's a good idea to be pedantic and add in the $PKG_INSTALL_ROOT
anyway, just in case someone decides to use it as a template for
something that does actually need it.


More information about the maintainers mailing list