[csw-maintainers] Error: Ambiguous "?:" expression

[Philip Brown]

On Tue, Mar 9, 2010 at 2:33 PM, Roger Håkansson <hson at opencsw.org> wrote:
>
>>
>> that's.... a wierd definition.
>> methinks its using gnuism of defaulting to "return null" or something,
>> and you will need to do the return explicitly?
>
> ERROR_LOG is defined as:
>  if(true) { \
>  std::cerr << __FILE__ << ":" << __LINE__ << " ASSSERTION FAILED: " << a <<
> std::endl; \
>  abort(); \
>  } else (void)0

"else 0" ???  that's just freakin wierd.

perhaps if you changed that to

else return(NULL)

or something, it might be the simplest one-spot patch.

or manage the cast to void somehow.
Dunno if c++ allows return(void)
:-}


contrariwise, since  the "else" clause should NEVER BE CALLED, just
remove it entirely, and see if that makes things happy?

> Anyway, I've created a patchfile (/home/hson/generator_private.hpp.diff on
> buildfarm) which at least makes generator.cpp compile, but I can't assure
> for functionality.
> Basically I've added "return tpoint(0,0)" for those functions returning
> tpoint and "return NULL" for those returning twidget.
>