[csw-maintainers] pstamp check

[Maciej (Matchek) Blizinski]

On Sat, Mar 13, 2010 at 1:40 PM, Roger Håkansson <hson at opencsw.org> wrote:
> After updating gar on my "buildfarm" I got some new errors from checkpkg.
> After some investigation it seems that some old checkpkg tests have been
> backported to python, but the check for pstamp doesn't seem to have a flaw
> in it.
> If the hostname have a '-' in it the check fails.
> I've worked around it using "CHECKPKG_OVERRIDES +=
> pkginfo-pstamp-in-wrong-format" in my .garrc, but someone else might benefit
> from a bug fix...
>
> Output:
> -------------------------------
> There were errors reported.
> If you know they are false positives, you can override them:
> CHECKPKG_OVERRIDES_CSWlibrsvgmozilla +=
> pkginfo-pstamp-in-wrong-format|hson at solaris9s-csw-20100313144445
> CHECKPKG_OVERRIDES_CSWlibrsvggnome +=
> pkginfo-pstamp-in-wrong-format|hson at solaris9s-csw-20100313144437
> CHECKPKG_OVERRIDES_CSWlibrsvg +=
> pkginfo-pstamp-in-wrong-format|hson at solaris9s-csw-20100313144412
> CHECKPKG_OVERRIDES_CSWlibrsvgdevel +=
> pkginfo-pstamp-in-wrong-format|hson at solaris9s-csw-20100313144421
> CHECKPKG_OVERRIDES_CSWrsvg +=
> pkginfo-pstamp-in-wrong-format|hson at solaris9s-csw-20100313144453
> CHECKPKG_OVERRIDES_CSWlibrsvgdoc +=
> pkginfo-pstamp-in-wrong-format|hson at solaris9s-csw-20100313144429

For these to work, you would need to remove the parameter and leave only:

CHECKPKG_OVERRIDES_CSWlibrsvgdoc += pkginfo-pstamp-in-wrong-format

(etc.)

The reason is that at every package creation the pstamp is updated to
a new value, and the old override wouldn't match the new pstamp.

But the real fix is to allow the minus sign in the host name.  While
writing a unit test for it, I also discovered a bug in the regex.
r9141 fixes both issues:

https://sourceforge.net/apps/trac/gar/changeset/9141

Thanks for the report, Roger!

Maciej