[csw-maintainers] openldaprc file is missing, slapd.conf not found by service start method

[Geoff Davis]

On Oct 19, 2010, at 11:14 PM, Dagobert Michelsen wrote:

> Hi Geoff,
> 
> Anfang der weitergeleiteten E-Mail:
>> ----------------------------------------------------------------------
>> (0008382) gadavis (developer) - 2010-10-20 00:00
>> https://www.opencsw.org/mantis/view.php?id=4521#c8382
>> ----------------------------------------------------------------------
>> +1 for a fix, this was a frustrating bug to stumble upon.
> 
> Feel free to join the OpenLDAP-team :-) I am really sorry, but I am currently
> arms deep in other (work related) stuff...
> 
> 
> Best regards
> 
> -- Dago


I'd love to jump in to tweak a couple of things about this package, but I have a lot of questions about this Makefile and where files are supposed to be installed.

First question:

Lines 18-21 of the Makefile at r11146 [1]:

DISTFILES  = $(SOURCEFILES)
DISTFILES += CSWoldap.postinstall
DISTFILES += README.CSW openldaprc
DISTFILES += cswopenldap openldap.xml svc-openldap

Why are a bunch of files that are not part of the Sourceforge distribution and that could never be downloaded from Sourceforge being added to the DISTFILES variable? Should those lines be deleted, or is this some special usage of DISTFILES that is undocumented in the GAR Variable Reference? [2] I'm guessing that it's the latter, and that this is a hack to get the files to be placed in $DOWNLOADDIR so that the build process can use them. Is there a "proper" way to do this?

Second question:

The init script [3] and README.CSW [4] both make reference to /opt/csw/etc/openldap as the default configuration directory. However, when I install the package, all of the configuration files end up in /etc/opt/csw/openldap

Same thing with the var stuff - README.CSW talks about /opt/csw/var/openldap but the package actually uses /var/opt/csw/openldap

I get the feeling from watching the maintainers list that the configuration file locations are still up for discussion, but I'd at least like to set some sane working defaults consistent with whatever is mechanism is installing the configuration files.

So which paths should I use as the default configuration file locations in the init script [3] and the default opencswrc file [5]? /etc/opt/csw/openldap and /var/opt/csw/openldap
-OR-
/opt/csw/etc/openldap and /opt/csw/var/openldap

Third question:

The init script [3] talks about a file called openldaprc [5] that isn't being included in this package but does exist in the repository, which is what the original bug [6] was about. It specifically mentions installing openldaprc by hand:

(from lines 14-17 in [3]):
# For example,
#  mkdir -p /etc/opt/csw
#  cp /opt/csw/share/doc/openldap/openldaprc /etc/opt/csw/

Is /opt/csw/share/doc/openldap/openldaprc the correct location for that sample file?

Fourth Question:

Why does the Makefile Line 57 [7] put the Patch files in the docs directory?
EXTRA_DOCS = README.CSW $(PATCHFILES)

Sorry for all of the questions, but I'm still trying to get my head around all of the various rules of thumb that are used here for packaging.

[1] http://sourceforge.net/apps/trac/gar/browser/csw/mgar/pkg/openldap/trunk/Makefile?rev=11146#L18
[2] http://sourceforge.net/apps/trac/gar/wiki/GAR%20Variable%20Reference#DownloadSettings
[3] http://sourceforge.net/apps/trac/gar/browser/csw/mgar/pkg/openldap/trunk/files/cswopenldap?rev=11146
[4] http://sourceforge.net/apps/trac/gar/browser/csw/mgar/pkg/openldap/trunk/files/README.CSW?rev=11146
[5] http://sourceforge.net/apps/trac/gar/browser/csw/mgar/pkg/openldap/trunk/files/openldaprc?rev=11146
[6] https://www.opencsw.org/mantis/view.php?id=4521
[7] http://sourceforge.net/apps/trac/gar/browser/csw/mgar/pkg/openldap/trunk/Makefile?rev=11146#L57