[csw-maintainers] [ITP] gdb 7.2

[Peter FELECAN]

Dagobert Michelsen <dam at opencsw.org> writes:

> Hi Peter,
>
> Am 08.01.2011 um 14:06 schrieb Peter FELECAN:
>> Dagobert Michelsen <dam at opencsw.org> writes:
>>> Am 08.01.2011 um 10:43 schrieb Peter FELECAN:
>>>> Ben Walton <bwalton at opencsw.org> writes:
>>>>> Excerpts from Peter FELECAN's message of Fri Jan 07 03:23:59 -0500 2011:
>>>>> 
>>>>>> I think that we can use libintl without much worry; the kludgy way
>>>>>> that they use to alleviate a SUN libc issue will fade away when the
>>>>>> support for Solaris 9 is terminated. Anyway, caution is always a
>>>>>> good stance.
>>>>> 
>>>>> I have a mostly up-to-date build description for ggettext ready to go,
>>>>> but I stalled it while waiting for the arbitration results.  It needs
>>>>> a bit of testing yet too.
>>>>> 
>>>>> I think this package would benefit from being built separately on sol9
>>>>> and sol10 so that this issue only affects sol9.  I'll try to get back
>>>>> to this, but if someone else wants to pick it up, most of the work is
>>>>> done already.
>>>> 
>>>> I don't think that is necessary to have separate packages. In the code
>>>> that I cited in my detailed mail, you can add a run-time detection of
>>>> the release of Solaris on which it actually runs and act accordingly. I
>>>> can provide an easy patch , preferably for 0.18.1. If we validate this,
>>>> we can submit the patch upstream.
>>> 
>>> That would be excellent!!
>> 
>> Note that I'll publicly provide the patch only on request from the
>> person who intent to package a new gettext set based on 0.18.1 or
>> greater.
>
> As Ben already did most of the work I'll of course let him the honour
> of submitting it :-) Of course I lend him a hand if necesssary, so
> you can already start patching!

Here are the patches, to apply on the 0.18.1 release of gettext, and the
report that I made to the upstream project
http://savannah.gnu.org/bugs/?32087

                 Summary: libpthread linkage detection on Solaris
                 Project: GNU gettext
            Submitted by: pfelecan
            Submitted on: Mon 10 Jan 2011 11:31:30 AM CET
                Category: None
                Severity: 3 - Normal
              Item Group: None
                  Status: None
                 Privacy: Public
             Assigned to: None
             Open/Closed: Open
         Discussion Lock: Any

    _______________________________________________________

Details:

While I package gdb on Solaris 10 for the Open CSW project
(http://www.opencsw.org/) I found that the dynamic detection for
linking with pthread library by creating an ephemeral thread triggers
an assertion in gdb's thread management. This is clearly a bug in gdb
which I'll report on the corresponding system.

However, this behavior can be avoided by changing the detection
method.

Solaris 9 and previous had an issue with defining the POSIX thread
related symbols in libc but with non operational code. For this
reason, a test in the configure process is made in
gettext-runtime/m4/threadlib.m4 and if it detects that we are
configuring on Solaris the dynamic detection in activated in the
threadlib.c code in 3 sub-directories.

On Solaris 10 and later releases the original reason is no more
pertinent as the defined symbols in libc are correct. I tested
this on SPARC and Intel using the code in threadlib.c and without
linking with libpthread.

Consequently I propose a 2 pronged patch:

1. if the package is configured on Solaris 10 or later do not
   activate PTHREAD_IN_USE_DETECTION_HARD.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: thread_configure_solaris10.patch
Type: text/x-patch
Size: 1681 bytes
Desc: Configuration
URL: <http://lists.opencsw.org/pipermail/maintainers/attachments/20110110/f5658c77/attachment-0002.bin>
-------------- next part --------------


2. if the package is configured and built on Solaris 9 or previous but
   run on Solaris 10 or later the test using the ephemeral thread is
   not necessary.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: thread_run_solaris10.patch
Type: text/x-patch
Size: 4417 bytes
Desc: Run
URL: <http://lists.opencsw.org/pipermail/maintainers/attachments/20110110/f5658c77/attachment-0003.bin>
-------------- next part --------------


-- 
Peter