[csw-maintainers] Checkpgk error when having too long names

[Peter Bonivart]

On Sun, Jul 8, 2012 at 4:54 PM, Maciej (Matchek) Bliziński
<maciej at opencsw.org> wrote:
> 2012/7/8 Peter Bonivart <bonivart at opencsw.org>
>>
>> That's OK but I would like to get a proper error for it, not that
>> checkpkg collapses. :) Maybe GAR could tell me if it changes stuff on
>> the fly or maybe we could put it in mgar.
>
> One failure mode I would guess is that one check in package_checks.py
> is passing an int instead of a unicode or a string object.
>
> Try adding this patch and recreating the problem:
>
> diff --git a/gar/v2/lib/python/checkpkg_lib.py
> b/gar/v2/lib/python/checkpkg_lib.py
> index 17f07aa..e319ec8 100644
> --- a/gar/v2/lib/python/checkpkg_lib.py
> +++ b/gar/v2/lib/python/checkpkg_lib.py
> @@ -249,7 +249,7 @@ class CheckpkgManagerBase(SqlobjectHelperMixin):
>              srv4_file=db_stat_objs_by_pkgname[e.pkgname],
>              pkgname=e.pkgname,
>              tag_name=e.tag_name,
> -            tag_info=e.tag_info,
> +            tag_info=unicode(e.tag_info),
>              msg=e.msg,
>              os_rel=sqo_os_rel,
>              catrel=sqo_catrel,
>
> What extra error tag do you get after adding this patch?

It doesn't blow up now which is good but it still doesn't tell me what's wrong:

INFO:root:Juicing the svr4 package stream files...
100% |#########################################################################|
INFO:root:Unwrapping candies...
100% |#########################################################################|
INFO:root:Tasting candies one by one...
WARNING:CSWpm-cgi-session-serialize-yaml-CheckPkgchk:pkgchk: ERROR:
attempt to process datastream failed
WARNING:CSWpm-cgi-session-serialize-yaml-CheckPkgchk:    - package
<CSWpm-cgi-session-serialize-yaml> not in datastream
WARNING:CSWpm-cgi-session-serialize-yaml-CheckPkgchk:pkgchk: ERROR:
unable to complete package transfer
100% |#########################################################################|
INFO:root:Tasting them all at once...
INFO:root:Stuffing the candies under the pillow...
100% |#########################################################################|
CSWpm-cgi-session-serialize-yaml:
If any of the reported errors were false positives, you can override them
pasting the lines below to the GAR recipe.
CHECKPKG_OVERRIDES_CSWpm-cgi-session-serialize-yaml += pkgchk-failed-with-code|1
CHECKPKG_OVERRIDES_CSWpm-cgi-session-serialize-yaml +=
pkginfo-opencsw-repository-uncommitted|None

I assume the truncation happened before checkpkg gets a hold of the
package, that's why I suggested a check in mgar or GAR.