[csw-maintainers] Checkpgk error when having too long names

[Peter Bonivart]

On Sun, Jul 8, 2012 at 5:59 PM, Maciej Bliziński <maciej at opencsw.org> wrote:
> On Sun, Jul 08, 2012 at 05:43:50PM +0200, Peter Bonivart wrote:
>> It doesn't blow up now which is good but it still doesn't tell me what's wrong:
>
> How does it not tell you?

I don't think it's obvious how to correct the problem. Not in
datastream == pkgname too long?

>> INFO:root:Juicing the svr4 package stream files...
>> 100% |#########################################################################|
>> INFO:root:Unwrapping candies...
>> 100% |#########################################################################|
>> INFO:root:Tasting candies one by one...
>> WARNING:CSWpm-cgi-session-serialize-yaml-CheckPkgchk:pkgchk: ERROR:
>> attempt to process datastream failed
>> WARNING:CSWpm-cgi-session-serialize-yaml-CheckPkgchk:    - package
>> <CSWpm-cgi-session-serialize-yaml> not in datastream
>> WARNING:CSWpm-cgi-session-serialize-yaml-CheckPkgchk:pkgchk: ERROR:
>> unable to complete package transfer
>> 100% |#########################################################################|
>> INFO:root:Tasting them all at once...
>> INFO:root:Stuffing the candies under the pillow...
>> 100% |#########################################################################|
>> CSWpm-cgi-session-serialize-yaml:
>> If any of the reported errors were false positives, you can override them
>> pasting the lines below to the GAR recipe.
>
> Just read this bit:
>
>> CHECKPKG_OVERRIDES_CSWpm-cgi-session-serialize-yaml += pkgchk-failed-with-code|1
>> CHECKPKG_OVERRIDES_CSWpm-cgi-session-serialize-yaml +=
>> pkginfo-opencsw-repository-uncommitted|None
>
> "pkgchk-failed-with-code|1" means that pkgchk (/usr/sbin/pkgchk) failed
> with system error code equal to 1.

Even reading the man page for pkgchk I only get this:

     >0    An error occurred.

>> I assume the truncation happened before checkpkg gets a hold of the
>> package, that's why I suggested a check in mgar or GAR.
>
> checkpkg shouldn't crash either way.
>
> Fix committed in r18664.
>
> http://sourceforge.net/apps/trac/gar/changeset/18664
>
> Just to make sure everyone is aware: pkgchk != checkpkg (sic!)
>
> /usr/sbin/pkgchk: Sun utility from the SUNWpkgcmdsu package. This is the
> one you use map from files to packages on a Solaris system (pkgchk -l -p foo)
>
> checkpkg: OpenCSW utility designed to check OpenCSW packages. Lives in
> GAR sources.

Well, that's why I suggested a check before checkpkg gets executed...