[csw-maintainers] please review new emacs_template recipe

Peter FELECAN pfelecan at opencsw.org
Tue Jun 12 19:17:11 CEST 2012


Dagobert Michelsen <dam at opencsw.org> writes:

> Hi Peter,
>
> Am 11.06.2012 um 19:18 schrieb Peter FELECAN:
>> Dagobert Michelsen <dam at opencsw.org> writes:
>>> This is an automatic thing, a file README.CSW will be added to all build packages
>>> of this recipe to announce general changes etc. I guess it should be added to 
>>> the variable reference. Any other name apart from README.CSW will not have this
>>> behaviour.
>> 
>> And how do you add the README.CSW file only to a given package? You did
>> remark that the "other" package is a stub used because the original
>> package name changes. This is quite annoying even though I see a
>> solution by using another mechanism to add the file, e.g. in
>> post-install-modulated.
>
> That "feature" was introduced after a discussion on IRC in februar 2011 AFAIR.
> Now that I think it over it may not be as clean as it should be. To be in line it
> probably should be
>   DISTFILES += CSWmypkg.README.CSW
> or even better
>   DISTFILES += README.CSW
>   EXTRA_DOCS_CSWmypkg += README.CSW
>   EXTRA_DOCS_CSWmypkg += morestuff.txt
>   EXTRA_DOCS += this-goes-to-all-pkgs.txt
>
> Would that be ok?

I think that the second form is more in line with the other package
specific variables.

Note that my issue included README.CSW in 2 subdirectories of the
package's doc, i.e. /opt/csw/share/doc/emacs_template/emacs_template and
/opt/csw/share/doc/emacs_template/emacs_template_stub

-- 
Peter


More information about the maintainers mailing list