[csw-maintainers] Modifying check for /usr/share

[Dagobert Michelsen]

Hi folks,

Am 13.04.2013 um 11:18 schrieb Peter FELECAN <pfelecan at opencsw.org>:
> "Maciej (Matchek) Bliziński" <maciej at opencsw.org> writes:
>> 2013/4/12 Peter FELECAN <pfelecan at opencsw.org>:
>>>> I would like to suggest a change in the check for /usr/share presence, where the presence of
>>>> /usr/share/lib/zoneinfo is acceptable, as this should be taken from the system. Thoughts?
>>> 
>>> If we don't provide a specific "zoneinfo" file, and why should we ?,
>>> then this seems very reasonable.
>> 
>> I have a general feeling that these content checks are too broad and
>> produce so many false positives, that they border on unhelpful.  Maybe
>> we should make them less broad as the first measure. For starters,
>> they should only concern binaries.
>> 
>> We could also review how useful they are in the long run. We did have
>> a bug caused by a reference to /usr/share, but if this check did not
>> help us since, we can remove it without losing much.
> 
> Globally agree with you. IMHO we can exclude from this kind of check the
> Info files, the manual pages and the documentation in general. Also,
> specific files as "zoneinfo" are good candidates. But removing all these
> checks is not a good solution.

I would like to keep the check, there have been occasions where this was extremely useful
and helped point out issues which were gone by unnoticed. Taking out the known-to-be-good
pathes is IMHO the best way.


Best regards

  -- Dago


-- 
"You don't become great by trying to be great, you become great by wanting to do something,
and then doing it so hard that you become great in the process." - xkcd #896