[csw-users] A build for review: rxvt-unicode

[William Bonnet]

Hi Maciej

Here is a quick review of your package

. name of the directory containing the Makefile etc. should be name like 
the package ( urxvt )

. CATEGORIES = x11
    This category is used to build x11 libs, not for all programs 
running under x11.
    It does not mean it is an error nor it should not be used. But some 
applications uses x11, some gnome, some apps. So i warn you to be sure 
you have checked what is defined by this category file.

. UFILES_REGEX should be
    UFILES_REGEX = $(GARNAME)-(\d+(?:\.\d+)*).tar.bz2= 
$(GARNAME)-(\d+(?:\.\d+)*).tar.bz2
    The regular expression has to match the filename of the source file 
you download
    ( not your fault, i'm late at releasing this documentation ;) )

. You are using GCC ? is there a reason why you cannot use SunStudio 11 ?
    I tried but it does not compile. I think you should look if it is 
possible or not to propose a patch to make it work with sunstudio.

. You should add the following line to your Makefile
    TEST_SCRIPTS =
    It will prevent GAR from trying to run tests since the software does 
provide some

. If you don't provide a depend file and use automatic generation (which 
is good), you should declare dependencies in the Makefile. Add the 
following line :
    REQUIRED_PKGS_CSWurxvt = CSWfconfig CSWftype2 CSWlibxft2 
CSWlibxrender CSWzlib

You can find which package are necessary after first build. In the case 
of this package the ouput is :

Examining 'depend' file
system      CSWcommon common - common files and dirs for CSW packages
SUGGESTION: you may want to add some or all of the following as depends:
   (Feel free to ignore SUNW or SPRO packages)
 > CSWfconfig
 > CSWftype2
 > CSWlibxft2
 > CSWlibxrender
 > CSWzlib
 > SUNWcsl
 > SUNWcslr
 > SUNWdpl
 > SUNWfontconfig
 > SUNWfreetype2
 > SUNWlibms
 > SUNWlibmsr
 > SUNWxwplt
 > SUNWxwrtl
 > SUNWxwxft
 > SUNWzlib

You have to add all CSW* packages

If you rebuild after adding deps you have :

Examining 'depend' file
system      CSWcommon common - common files and dirs for CSW packages
application CSWfconfig fontconfig - A library for configuring and 
customizing font access.
application CSWftype2 freetype2 - A free and portable TrueType font 
rendering engine
application CSWlibxft2 libxft2 - FreeType-based font drawing library for X
application CSWlibxrender libxrender - fontconfig.org Xrender library
application CSWzlib zlib - Zlib Data Compression Library
SUGGESTION: you may want to add some or all of the following as depends:
   (Feel free to ignore SUNW or SPRO packages)
 > SUNWcsl
 > SUNWcslr
 > SUNWdpl
 > SUNWfontconfig
 > SUNWfreetype2
 > SUNWlibms
 > SUNWlibmsr
 > SUNWxwplt
 > SUNWxwrtl
 > SUNWxwxft
 > SUNWzlib

I compiled it and installed on a test VM and it works.

Thanks for this contribution and your good work. It is almost ready, you 
can submit it and finish your work on the farm.

Regards,
W.

-- 

William                  http://www.wbonnet.net

http://www.sunwizard.net Le site français des amateurs de stations Unix
http://www.opencsw.org 	 Community SoftWare for Solaris
http://www.guses.org     French speaking Solaris User Group