From csardi.gabor at gmail.com  Fri Apr 24 16:47:05 2020
From: csardi.gabor at gmail.com (=?UTF-8?B?R8OhYm9yIENzw6FyZGk=?=)
Date: Fri, 24 Apr 2020 15:47:05 +0100
Subject: r_base 3.3.0 -> 3.6.3
Message-ID: <CABtg=Kn-aYU4i5TT5g33v18R5t7uUF44UcoB6N3NagUC+DWcGg@mail.gmail.com>

Hi all, I managed to update the r_base package to 3.6.3, Jan or
somebody else interested in a minimal patch?

(Sending messages from the web page does not work, btw.)

Cheers,
Gabor

From dam at opencsw.org  Fri Apr 24 18:33:45 2020
From: dam at opencsw.org (Dagobert Michelsen)
Date: Fri, 24 Apr 2020 18:33:45 +0200
Subject: r_base 3.3.0 -> 3.6.3
In-Reply-To: <CABtg=Kn-aYU4i5TT5g33v18R5t7uUF44UcoB6N3NagUC+DWcGg@mail.gmail.com>
References: <CABtg=Kn-aYU4i5TT5g33v18R5t7uUF44UcoB6N3NagUC+DWcGg@mail.gmail.com>
Message-ID: <12B3A621-20EC-42A5-8A94-7EB809D22863@opencsw.org>

Hi Gabor,

> Am 24.04.2020 um 16:47 schrieb G?bor Cs?rdi via users <users at lists.opencsw.org>:
> 
> Hi all, I managed to update the r_base package to 3.6.3, Jan or
> somebody else interested in a minimal patch?
> 
> (Sending messages from the web page does not work, btw.)

Sure, just send them over :-)


Best regards

  ? Dago

-- 
"You don't become great by trying to be great, you become great by wanting to do something,
and then doing it so hard that you become great in the process." - xkcd #896


From csardi.gabor at gmail.com  Fri Apr 24 19:38:23 2020
From: csardi.gabor at gmail.com (=?UTF-8?B?R8OhYm9yIENzw6FyZGk=?=)
Date: Fri, 24 Apr 2020 18:38:23 +0100
Subject: r_base 3.3.0 -> 3.6.3
In-Reply-To: <12B3A621-20EC-42A5-8A94-7EB809D22863@opencsw.org>
References: <CABtg=Kn-aYU4i5TT5g33v18R5t7uUF44UcoB6N3NagUC+DWcGg@mail.gmail.com>
 <12B3A621-20EC-42A5-8A94-7EB809D22863@opencsw.org>
Message-ID: <CABtg=KmrWq+P1NLFBHNkJE7+GhySQOVW7QL6QYAt_WBhEPw0Tg@mail.gmail.com>

OK, in a minute, but first a quick question. Does the build server
create a minimal environment wrt dependencies?

E.g. it turned out that to build this, I needed libfreetype_dev, but
that was not in the listed dependencies. If I miss this and do not
update the dependencies, will the build server notice?

Thanks,
Gabor

On Fri, Apr 24, 2020 at 5:33 PM Dagobert Michelsen <dam at opencsw.org> wrote:
>
> Hi Gabor,
>
> > Am 24.04.2020 um 16:47 schrieb G?bor Cs?rdi via users <users at lists.opencsw.org>:
> >
> > Hi all, I managed to update the r_base package to 3.6.3, Jan or
> > somebody else interested in a minimal patch?
> >
> > (Sending messages from the web page does not work, btw.)
>
> Sure, just send them over :-)
>
>
> Best regards
>
>   ? Dago
>
> --
> "You don't become great by trying to be great, you become great by wanting to do something,
> and then doing it so hard that you become great in the process." - xkcd #896
>

From dam at opencsw.org  Fri Apr 24 20:18:43 2020
From: dam at opencsw.org (Dagobert Michelsen)
Date: Fri, 24 Apr 2020 20:18:43 +0200
Subject: r_base 3.3.0 -> 3.6.3
In-Reply-To: <CABtg=KmrWq+P1NLFBHNkJE7+GhySQOVW7QL6QYAt_WBhEPw0Tg@mail.gmail.com>
References: <CABtg=Kn-aYU4i5TT5g33v18R5t7uUF44UcoB6N3NagUC+DWcGg@mail.gmail.com>
 <12B3A621-20EC-42A5-8A94-7EB809D22863@opencsw.org>
 <CABtg=KmrWq+P1NLFBHNkJE7+GhySQOVW7QL6QYAt_WBhEPw0Tg@mail.gmail.com>
Message-ID: <CBBDE426-C7D7-4C10-9464-C2AAE48D7103@opencsw.org>

Hi Gabor,

Am 24.04.2020 um 19:38 schrieb G?bor Cs?rdi <csardi.gabor at gmail.com>:
> OK, in a minute, but first a quick question. Does the build server
> create a minimal environment wrt dependencies?
> 
> E.g. it turned out that to build this, I needed libfreetype_dev, but
> that was not in the listed dependencies. If I miss this and do not
> update the dependencies, will the build server notice?

The development dependencies are sometimes listed in GAR - they should be,
but it is not minimal as the build servers are statically set up.
Usually a build dependency results in a runtime dependency to a
coresponding shared library and that would be noticed.


Best regards

  ? Dago

> 
> Thanks,
> Gabor
> 
> On Fri, Apr 24, 2020 at 5:33 PM Dagobert Michelsen <dam at opencsw.org> wrote:
>> 
>> Hi Gabor,
>> 
>>> Am 24.04.2020 um 16:47 schrieb G?bor Cs?rdi via users <users at lists.opencsw.org>:
>>> 
>>> Hi all, I managed to update the r_base package to 3.6.3, Jan or
>>> somebody else interested in a minimal patch?
>>> 
>>> (Sending messages from the web page does not work, btw.)
>> 
>> Sure, just send them over :-)
>> 
>> 
>> Best regards
>> 
>>  ? Dago
>> 
>> --
>> "You don't become great by trying to be great, you become great by wanting to do something,
>> and then doing it so hard that you become great in the process." - xkcd #896
>> 

-- 
"You don't become great by trying to be great, you become great by wanting to do something,
and then doing it so hard that you become great in the process." - xkcd #896


From csardi.gabor at gmail.com  Sun Apr 26 14:31:51 2020
From: csardi.gabor at gmail.com (=?UTF-8?B?R8OhYm9yIENzw6FyZGk=?=)
Date: Sun, 26 Apr 2020 13:31:51 +0100
Subject: r_base 3.3.0 -> 3.6.3
In-Reply-To: <CBBDE426-C7D7-4C10-9464-C2AAE48D7103@opencsw.org>
References: <CABtg=Kn-aYU4i5TT5g33v18R5t7uUF44UcoB6N3NagUC+DWcGg@mail.gmail.com>
 <12B3A621-20EC-42A5-8A94-7EB809D22863@opencsw.org>
 <CABtg=KmrWq+P1NLFBHNkJE7+GhySQOVW7QL6QYAt_WBhEPw0Tg@mail.gmail.com>
 <CBBDE426-C7D7-4C10-9464-C2AAE48D7103@opencsw.org>
Message-ID: <CABtg=Kkefrky4w8vYncWA597gTyLDB6Z2foFqKtBhoufEQ6Abg@mail.gmail.com>

OK, patch is attached. It has

- a new configure option: --with-internal-tzcode The R Admin manual
claims that this works better than the built-in time zone support.
- a small patch, because the presence of utimensat() function is mis-detected
- added libfreetype6 as a run-time dependency. The solaris version
seems to be 32 bit only

I'll try to build the new 4.0.0 version as well.

Thanks much!
Gabor

On Fri, Apr 24, 2020 at 7:18 PM Dagobert Michelsen <dam at opencsw.org> wrote:
>
> Hi Gabor,
>
> Am 24.04.2020 um 19:38 schrieb G?bor Cs?rdi <csardi.gabor at gmail.com>:
> > OK, in a minute, but first a quick question. Does the build server
> > create a minimal environment wrt dependencies?
> >
> > E.g. it turned out that to build this, I needed libfreetype_dev, but
> > that was not in the listed dependencies. If I miss this and do not
> > update the dependencies, will the build server notice?
>
> The development dependencies are sometimes listed in GAR - they should be,
> but it is not minimal as the build servers are statically set up.
> Usually a build dependency results in a runtime dependency to a
> coresponding shared library and that would be noticed.
>
>
> Best regards
>
>   ? Dago
>
> >
> > Thanks,
> > Gabor
> >
> > On Fri, Apr 24, 2020 at 5:33 PM Dagobert Michelsen <dam at opencsw.org> wrote:
> >>
> >> Hi Gabor,
> >>
> >>> Am 24.04.2020 um 16:47 schrieb G?bor Cs?rdi via users <users at lists.opencsw.org>:
> >>>
> >>> Hi all, I managed to update the r_base package to 3.6.3, Jan or
> >>> somebody else interested in a minimal patch?
> >>>
> >>> (Sending messages from the web page does not work, btw.)
> >>
> >> Sure, just send them over :-)
> >>
> >>
> >> Best regards
> >>
> >>  ? Dago
> >>
> >> --
> >> "You don't become great by trying to be great, you become great by wanting to do something,
> >> and then doing it so hard that you become great in the process." - xkcd #896
> >>
>
> --
> "You don't become great by trying to be great, you become great by wanting to do something,
> and then doing it so hard that you become great in the process." - xkcd #896
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: r-base-3.6.3.patch
Type: application/octet-stream
Size: 2228 bytes
Desc: not available
URL: <http://lists.opencsw.org/pipermail/users/attachments/20200426/52479c05/attachment.obj>

From csardi.gabor at gmail.com  Sun Apr 26 15:42:09 2020
From: csardi.gabor at gmail.com (=?UTF-8?B?R8OhYm9yIENzw6FyZGk=?=)
Date: Sun, 26 Apr 2020 14:42:09 +0100
Subject: r_base 3.3.0 -> 3.6.3
In-Reply-To: <CABtg=Kkefrky4w8vYncWA597gTyLDB6Z2foFqKtBhoufEQ6Abg@mail.gmail.com>
References: <CABtg=Kn-aYU4i5TT5g33v18R5t7uUF44UcoB6N3NagUC+DWcGg@mail.gmail.com>
 <12B3A621-20EC-42A5-8A94-7EB809D22863@opencsw.org>
 <CABtg=KmrWq+P1NLFBHNkJE7+GhySQOVW7QL6QYAt_WBhEPw0Tg@mail.gmail.com>
 <CBBDE426-C7D7-4C10-9464-C2AAE48D7103@opencsw.org>
 <CABtg=Kkefrky4w8vYncWA597gTyLDB6Z2foFqKtBhoufEQ6Abg@mail.gmail.com>
Message-ID: <CABtg=K=-Pf-twPpn0X9UCfvzQdfjaBAFcA3Hcv0h9TiLf9kd-g@mail.gmail.com>

Actually, building 4.0.0 was simple, so you might as well skip 3.6.3.
The new patch is attached.

Thanks,
Gabor

On Sun, Apr 26, 2020 at 1:31 PM G?bor Cs?rdi <csardi.gabor at gmail.com> wrote:
>
> OK, patch is attached. It has
>
> - a new configure option: --with-internal-tzcode The R Admin manual
> claims that this works better than the built-in time zone support.
> - a small patch, because the presence of utimensat() function is mis-detected
> - added libfreetype6 as a run-time dependency. The solaris version
> seems to be 32 bit only
>
> I'll try to build the new 4.0.0 version as well.
>
> Thanks much!
> Gabor
>
> On Fri, Apr 24, 2020 at 7:18 PM Dagobert Michelsen <dam at opencsw.org> wrote:
> >
> > Hi Gabor,
> >
> > Am 24.04.2020 um 19:38 schrieb G?bor Cs?rdi <csardi.gabor at gmail.com>:
> > > OK, in a minute, but first a quick question. Does the build server
> > > create a minimal environment wrt dependencies?
> > >
> > > E.g. it turned out that to build this, I needed libfreetype_dev, but
> > > that was not in the listed dependencies. If I miss this and do not
> > > update the dependencies, will the build server notice?
> >
> > The development dependencies are sometimes listed in GAR - they should be,
> > but it is not minimal as the build servers are statically set up.
> > Usually a build dependency results in a runtime dependency to a
> > coresponding shared library and that would be noticed.
> >
> >
> > Best regards
> >
> >   ? Dago
> >
> > >
> > > Thanks,
> > > Gabor
> > >
> > > On Fri, Apr 24, 2020 at 5:33 PM Dagobert Michelsen <dam at opencsw.org> wrote:
> > >>
> > >> Hi Gabor,
> > >>
> > >>> Am 24.04.2020 um 16:47 schrieb G?bor Cs?rdi via users <users at lists.opencsw.org>:
> > >>>
> > >>> Hi all, I managed to update the r_base package to 3.6.3, Jan or
> > >>> somebody else interested in a minimal patch?
> > >>>
> > >>> (Sending messages from the web page does not work, btw.)
> > >>
> > >> Sure, just send them over :-)
> > >>
> > >>
> > >> Best regards
> > >>
> > >>  ? Dago
> > >>
> > >> --
> > >> "You don't become great by trying to be great, you become great by wanting to do something,
> > >> and then doing it so hard that you become great in the process." - xkcd #896
> > >>
> >
> > --
> > "You don't become great by trying to be great, you become great by wanting to do something,
> > and then doing it so hard that you become great in the process." - xkcd #896
> >
-------------- next part --------------
A non-text attachment was scrubbed...
Name: r-base-4.0.0.patch
Type: application/octet-stream
Size: 2504 bytes
Desc: not available
URL: <http://lists.opencsw.org/pipermail/users/attachments/20200426/931b48ac/attachment-0001.obj>

From dam at opencsw.org  Sun Apr 26 16:32:46 2020
From: dam at opencsw.org (Dagobert Michelsen)
Date: Sun, 26 Apr 2020 16:32:46 +0200
Subject: r_base 3.3.0 -> 3.6.3
In-Reply-To: <CABtg=K=-Pf-twPpn0X9UCfvzQdfjaBAFcA3Hcv0h9TiLf9kd-g@mail.gmail.com>
References: <CABtg=Kn-aYU4i5TT5g33v18R5t7uUF44UcoB6N3NagUC+DWcGg@mail.gmail.com>
 <12B3A621-20EC-42A5-8A94-7EB809D22863@opencsw.org>
 <CABtg=KmrWq+P1NLFBHNkJE7+GhySQOVW7QL6QYAt_WBhEPw0Tg@mail.gmail.com>
 <CBBDE426-C7D7-4C10-9464-C2AAE48D7103@opencsw.org>
 <CABtg=Kkefrky4w8vYncWA597gTyLDB6Z2foFqKtBhoufEQ6Abg@mail.gmail.com>
 <CABtg=K=-Pf-twPpn0X9UCfvzQdfjaBAFcA3Hcv0h9TiLf9kd-g@mail.gmail.com>
Message-ID: <BC53DFB4-04A8-40F3-BF47-E3B1CF6311E6@opencsw.org>

Hi Gabor,

Am 26.04.2020 um 15:42 schrieb G?bor Cs?rdi <csardi.gabor at gmail.com>:
> Actually, building 4.0.0 was simple, so you might as well skip 3.6.3.
> The new patch is attached.

Excellent, the patch applied cleanly and the rebuild is running. If everything
is fine I?ll directly push 4.0.0 to unstable!


Thanks a lot and best regards

  ? Dago

> 
> Thanks,
> Gabor
> 
> On Sun, Apr 26, 2020 at 1:31 PM G?bor Cs?rdi <csardi.gabor at gmail.com> wrote:
>> 
>> OK, patch is attached. It has
>> 
>> - a new configure option: --with-internal-tzcode The R Admin manual
>> claims that this works better than the built-in time zone support.
>> - a small patch, because the presence of utimensat() function is mis-detected
>> - added libfreetype6 as a run-time dependency. The solaris version
>> seems to be 32 bit only
>> 
>> I'll try to build the new 4.0.0 version as well.
>> 
>> Thanks much!
>> Gabor
>> 
>> On Fri, Apr 24, 2020 at 7:18 PM Dagobert Michelsen <dam at opencsw.org> wrote:
>>> 
>>> Hi Gabor,
>>> 
>>> Am 24.04.2020 um 19:38 schrieb G?bor Cs?rdi <csardi.gabor at gmail.com>:
>>>> OK, in a minute, but first a quick question. Does the build server
>>>> create a minimal environment wrt dependencies?
>>>> 
>>>> E.g. it turned out that to build this, I needed libfreetype_dev, but
>>>> that was not in the listed dependencies. If I miss this and do not
>>>> update the dependencies, will the build server notice?
>>> 
>>> The development dependencies are sometimes listed in GAR - they should be,
>>> but it is not minimal as the build servers are statically set up.
>>> Usually a build dependency results in a runtime dependency to a
>>> coresponding shared library and that would be noticed.
>>> 
>>> 
>>> Best regards
>>> 
>>>  ? Dago
>>> 
>>>> 
>>>> Thanks,
>>>> Gabor
>>>> 
>>>> On Fri, Apr 24, 2020 at 5:33 PM Dagobert Michelsen <dam at opencsw.org> wrote:
>>>>> 
>>>>> Hi Gabor,
>>>>> 
>>>>>> Am 24.04.2020 um 16:47 schrieb G?bor Cs?rdi via users <users at lists.opencsw.org>:
>>>>>> 
>>>>>> Hi all, I managed to update the r_base package to 3.6.3, Jan or
>>>>>> somebody else interested in a minimal patch?
>>>>>> 
>>>>>> (Sending messages from the web page does not work, btw.)
>>>>> 
>>>>> Sure, just send them over :-)
>>>>> 
>>>>> 
>>>>> Best regards
>>>>> 
>>>>> ? Dago
>>>>> 
>>>>> --
>>>>> "You don't become great by trying to be great, you become great by wanting to do something,
>>>>> and then doing it so hard that you become great in the process." - xkcd #896
>>>>> 
>>> 
>>> --
>>> "You don't become great by trying to be great, you become great by wanting to do something,
>>> and then doing it so hard that you become great in the process." - xkcd #896
>>> 
> <r-base-4.0.0.patch>

-- 
"You don't become great by trying to be great, you become great by wanting to do something,
and then doing it so hard that you become great in the process." - xkcd #896


From csardi.gabor at gmail.com  Mon Apr 27 02:56:04 2020
From: csardi.gabor at gmail.com (=?UTF-8?B?R8OhYm9yIENzw6FyZGk=?=)
Date: Mon, 27 Apr 2020 01:56:04 +0100
Subject: r_base 3.3.0 -> 3.6.3
In-Reply-To: <BC53DFB4-04A8-40F3-BF47-E3B1CF6311E6@opencsw.org>
References: <CABtg=Kn-aYU4i5TT5g33v18R5t7uUF44UcoB6N3NagUC+DWcGg@mail.gmail.com>
 <12B3A621-20EC-42A5-8A94-7EB809D22863@opencsw.org>
 <CABtg=KmrWq+P1NLFBHNkJE7+GhySQOVW7QL6QYAt_WBhEPw0Tg@mail.gmail.com>
 <CBBDE426-C7D7-4C10-9464-C2AAE48D7103@opencsw.org>
 <CABtg=Kkefrky4w8vYncWA597gTyLDB6Z2foFqKtBhoufEQ6Abg@mail.gmail.com>
 <CABtg=K=-Pf-twPpn0X9UCfvzQdfjaBAFcA3Hcv0h9TiLf9kd-g@mail.gmail.com>
 <BC53DFB4-04A8-40F3-BF47-E3B1CF6311E6@opencsw.org>
Message-ID: <CABtg=K=u1z0e4gdgRz9DC2D_kAVWLWK6KFnpdJTnwOMTB9nPmQ@mail.gmail.com>

Thanks,

it is like I may have made a mistake for R 4.0.0 which needs PCRE2,
there is no libpcre2 package, but instead it is just pcre. I.e.

-RUNTIME_DEP_PKGS_CSWr-base += CSWlibpcre1
+RUNTIME_DEP_PKGS_CSWr-base += CSWpcre2

is the correct change. I have no idea how I could install this...

Sorry about it!
Thanks,
Gabor

On Sun, Apr 26, 2020 at 3:32 PM Dagobert Michelsen <dam at opencsw.org> wrote:
>
> Hi Gabor,
>
> Am 26.04.2020 um 15:42 schrieb G?bor Cs?rdi <csardi.gabor at gmail.com>:
> > Actually, building 4.0.0 was simple, so you might as well skip 3.6.3.
> > The new patch is attached.
>
> Excellent, the patch applied cleanly and the rebuild is running. If everything
> is fine I?ll directly push 4.0.0 to unstable!
>
>
> Thanks a lot and best regards
>
>   ? Dago
>
> >
> > Thanks,
> > Gabor
> >
> > On Sun, Apr 26, 2020 at 1:31 PM G?bor Cs?rdi <csardi.gabor at gmail.com> wrote:
> >>
> >> OK, patch is attached. It has
> >>
> >> - a new configure option: --with-internal-tzcode The R Admin manual
> >> claims that this works better than the built-in time zone support.
> >> - a small patch, because the presence of utimensat() function is mis-detected
> >> - added libfreetype6 as a run-time dependency. The solaris version
> >> seems to be 32 bit only
> >>
> >> I'll try to build the new 4.0.0 version as well.
> >>
> >> Thanks much!
> >> Gabor
> >>
> >> On Fri, Apr 24, 2020 at 7:18 PM Dagobert Michelsen <dam at opencsw.org> wrote:
> >>>
> >>> Hi Gabor,
> >>>
> >>> Am 24.04.2020 um 19:38 schrieb G?bor Cs?rdi <csardi.gabor at gmail.com>:
> >>>> OK, in a minute, but first a quick question. Does the build server
> >>>> create a minimal environment wrt dependencies?
> >>>>
> >>>> E.g. it turned out that to build this, I needed libfreetype_dev, but
> >>>> that was not in the listed dependencies. If I miss this and do not
> >>>> update the dependencies, will the build server notice?
> >>>
> >>> The development dependencies are sometimes listed in GAR - they should be,
> >>> but it is not minimal as the build servers are statically set up.
> >>> Usually a build dependency results in a runtime dependency to a
> >>> coresponding shared library and that would be noticed.
> >>>
> >>>
> >>> Best regards
> >>>
> >>>  ? Dago
> >>>
> >>>>
> >>>> Thanks,
> >>>> Gabor
> >>>>
> >>>> On Fri, Apr 24, 2020 at 5:33 PM Dagobert Michelsen <dam at opencsw.org> wrote:
> >>>>>
> >>>>> Hi Gabor,
> >>>>>
> >>>>>> Am 24.04.2020 um 16:47 schrieb G?bor Cs?rdi via users <users at lists.opencsw.org>:
> >>>>>>
> >>>>>> Hi all, I managed to update the r_base package to 3.6.3, Jan or
> >>>>>> somebody else interested in a minimal patch?
> >>>>>>
> >>>>>> (Sending messages from the web page does not work, btw.)
> >>>>>
> >>>>> Sure, just send them over :-)
> >>>>>
> >>>>>
> >>>>> Best regards
> >>>>>
> >>>>> ? Dago
> >>>>>
> >>>>> --
> >>>>> "You don't become great by trying to be great, you become great by wanting to do something,
> >>>>> and then doing it so hard that you become great in the process." - xkcd #896
> >>>>>
> >>>
> >>> --
> >>> "You don't become great by trying to be great, you become great by wanting to do something,
> >>> and then doing it so hard that you become great in the process." - xkcd #896
> >>>
> > <r-base-4.0.0.patch>
>
> --
> "You don't become great by trying to be great, you become great by wanting to do something,
> and then doing it so hard that you become great in the process." - xkcd #896
>

From dam at opencsw.org  Tue Apr 28 10:09:48 2020
From: dam at opencsw.org (Dagobert Michelsen)
Date: Tue, 28 Apr 2020 10:09:48 +0200
Subject: r_base 3.3.0 -> 3.6.3
In-Reply-To: <CABtg=KnVOJn5GqQCuOwBmb1gzrGj_3rjUjPeyRnEZLNAJFOMrQ@mail.gmail.com>
References: <CABtg=Kn-aYU4i5TT5g33v18R5t7uUF44UcoB6N3NagUC+DWcGg@mail.gmail.com>
 <12B3A621-20EC-42A5-8A94-7EB809D22863@opencsw.org>
 <CABtg=KmrWq+P1NLFBHNkJE7+GhySQOVW7QL6QYAt_WBhEPw0Tg@mail.gmail.com>
 <CBBDE426-C7D7-4C10-9464-C2AAE48D7103@opencsw.org>
 <CABtg=Kkefrky4w8vYncWA597gTyLDB6Z2foFqKtBhoufEQ6Abg@mail.gmail.com>
 <CABtg=K=-Pf-twPpn0X9UCfvzQdfjaBAFcA3Hcv0h9TiLf9kd-g@mail.gmail.com>
 <BC53DFB4-04A8-40F3-BF47-E3B1CF6311E6@opencsw.org>
 <CABtg=K=u1z0e4gdgRz9DC2D_kAVWLWK6KFnpdJTnwOMTB9nPmQ@mail.gmail.com>
 <CABtg=KnVOJn5GqQCuOwBmb1gzrGj_3rjUjPeyRnEZLNAJFOMrQ@mail.gmail.com>
Message-ID: <6A7F9D03-96D6-4301-A35F-91A99280CADB@opencsw.org>

Hi Gabor,

> Am 27.04.2020 um 03:27 schrieb G?bor Cs?rdi <csardi.gabor at gmail.com>:
> 
> Another mistake:
> 
> I used libreadline7, apparently, but the Makefile has libreadline6.
> 
> -RUNTIME_DEP_PKGS_CSWr-base += CSWlibreadline6
> +RUNTIME_DEP_PKGS_CSWr-base += CSWlibreadline7

I did some more adjustments:
  https://sourceforge.net/p/gar/code/26631/

The packages should show up here soon:
  http://buildfarm.opencsw.org/experimental.html#r_base

Please have a look and let me know if everything works so I can push them to unstable.


Best regards

  ? Dago

> 
> Hope this is all! Sorry for the sloppy job!
> Gabor
> 
> On Mon, Apr 27, 2020 at 1:56 AM G?bor Cs?rdi <csardi.gabor at gmail.com> wrote:
>> 
>> Thanks,
>> 
>> it is like I may have made a mistake for R 4.0.0 which needs PCRE2,
>> there is no libpcre2 package, but instead it is just pcre. I.e.
>> 
>> -RUNTIME_DEP_PKGS_CSWr-base += CSWlibpcre1
>> +RUNTIME_DEP_PKGS_CSWr-base += CSWpcre2
>> 
>> is the correct change. I have no idea how I could install this...
>> 
>> Sorry about it!
>> Thanks,
>> Gabor
>> 
>> On Sun, Apr 26, 2020 at 3:32 PM Dagobert Michelsen <dam at opencsw.org> wrote:
>>> 
>>> Hi Gabor,
>>> 
>>> Am 26.04.2020 um 15:42 schrieb G?bor Cs?rdi <csardi.gabor at gmail.com>:
>>>> Actually, building 4.0.0 was simple, so you might as well skip 3.6.3.
>>>> The new patch is attached.
>>> 
>>> Excellent, the patch applied cleanly and the rebuild is running. If everything
>>> is fine I?ll directly push 4.0.0 to unstable!
>>> 
>>> 
>>> Thanks a lot and best regards
>>> 
>>>  ? Dago
>>> 
>>>> 
>>>> Thanks,
>>>> Gabor
>>>> 
>>>> On Sun, Apr 26, 2020 at 1:31 PM G?bor Cs?rdi <csardi.gabor at gmail.com> wrote:
>>>>> 
>>>>> OK, patch is attached. It has
>>>>> 
>>>>> - a new configure option: --with-internal-tzcode The R Admin manual
>>>>> claims that this works better than the built-in time zone support.
>>>>> - a small patch, because the presence of utimensat() function is mis-detected
>>>>> - added libfreetype6 as a run-time dependency. The solaris version
>>>>> seems to be 32 bit only
>>>>> 
>>>>> I'll try to build the new 4.0.0 version as well.
>>>>> 
>>>>> Thanks much!
>>>>> Gabor
>>>>> 
>>>>> On Fri, Apr 24, 2020 at 7:18 PM Dagobert Michelsen <dam at opencsw.org> wrote:
>>>>>> 
>>>>>> Hi Gabor,
>>>>>> 
>>>>>> Am 24.04.2020 um 19:38 schrieb G?bor Cs?rdi <csardi.gabor at gmail.com>:
>>>>>>> OK, in a minute, but first a quick question. Does the build server
>>>>>>> create a minimal environment wrt dependencies?
>>>>>>> 
>>>>>>> E.g. it turned out that to build this, I needed libfreetype_dev, but
>>>>>>> that was not in the listed dependencies. If I miss this and do not
>>>>>>> update the dependencies, will the build server notice?
>>>>>> 
>>>>>> The development dependencies are sometimes listed in GAR - they should be,
>>>>>> but it is not minimal as the build servers are statically set up.
>>>>>> Usually a build dependency results in a runtime dependency to a
>>>>>> coresponding shared library and that would be noticed.
>>>>>> 
>>>>>> 
>>>>>> Best regards
>>>>>> 
>>>>>> ? Dago
>>>>>> 
>>>>>>> 
>>>>>>> Thanks,
>>>>>>> Gabor
>>>>>>> 
>>>>>>> On Fri, Apr 24, 2020 at 5:33 PM Dagobert Michelsen <dam at opencsw.org> wrote:
>>>>>>>> 
>>>>>>>> Hi Gabor,
>>>>>>>> 
>>>>>>>>> Am 24.04.2020 um 16:47 schrieb G?bor Cs?rdi via users <users at lists.opencsw.org>:
>>>>>>>>> 
>>>>>>>>> Hi all, I managed to update the r_base package to 3.6.3, Jan or
>>>>>>>>> somebody else interested in a minimal patch?
>>>>>>>>> 
>>>>>>>>> (Sending messages from the web page does not work, btw.)
>>>>>>>> 
>>>>>>>> Sure, just send them over :-)
>>>>>>>> 
>>>>>>>> 
>>>>>>>> Best regards
>>>>>>>> 
>>>>>>>> ? Dago
>>>>>>>> 
>>>>>>>> --
>>>>>>>> "You don't become great by trying to be great, you become great by wanting to do something,
>>>>>>>> and then doing it so hard that you become great in the process." - xkcd #896
>>>>>>>> 
>>>>>> 
>>>>>> --
>>>>>> "You don't become great by trying to be great, you become great by wanting to do something,
>>>>>> and then doing it so hard that you become great in the process." - xkcd #896
>>>>>> 
>>>> <r-base-4.0.0.patch>
>>> 
>>> --
>>> "You don't become great by trying to be great, you become great by wanting to do something,
>>> and then doing it so hard that you become great in the process." - xkcd #896
>>> 

-- 
"You don't become great by trying to be great, you become great by wanting to do something,
and then doing it so hard that you become great in the process." - xkcd #896


From csardi.gabor at gmail.com  Tue Apr 28 22:27:33 2020
From: csardi.gabor at gmail.com (=?UTF-8?B?R8OhYm9yIENzw6FyZGk=?=)
Date: Tue, 28 Apr 2020 21:27:33 +0100
Subject: r_base 3.3.0 -> 3.6.3
In-Reply-To: <6A7F9D03-96D6-4301-A35F-91A99280CADB@opencsw.org>
References: <CABtg=Kn-aYU4i5TT5g33v18R5t7uUF44UcoB6N3NagUC+DWcGg@mail.gmail.com>
 <12B3A621-20EC-42A5-8A94-7EB809D22863@opencsw.org>
 <CABtg=KmrWq+P1NLFBHNkJE7+GhySQOVW7QL6QYAt_WBhEPw0Tg@mail.gmail.com>
 <CBBDE426-C7D7-4C10-9464-C2AAE48D7103@opencsw.org>
 <CABtg=Kkefrky4w8vYncWA597gTyLDB6Z2foFqKtBhoufEQ6Abg@mail.gmail.com>
 <CABtg=K=-Pf-twPpn0X9UCfvzQdfjaBAFcA3Hcv0h9TiLf9kd-g@mail.gmail.com>
 <BC53DFB4-04A8-40F3-BF47-E3B1CF6311E6@opencsw.org>
 <CABtg=K=u1z0e4gdgRz9DC2D_kAVWLWK6KFnpdJTnwOMTB9nPmQ@mail.gmail.com>
 <CABtg=KnVOJn5GqQCuOwBmb1gzrGj_3rjUjPeyRnEZLNAJFOMrQ@mail.gmail.com>
 <6A7F9D03-96D6-4301-A35F-91A99280CADB@opencsw.org>
Message-ID: <CABtg=KkP7zqy6tu2pNB1cojOL_7AntFFhVcWVw8zpQGeLmO2sw@mail.gmail.com>

On Tue, Apr 28, 2020 at 9:10 AM Dagobert Michelsen <dam at opencsw.org> wrote:
> I did some more adjustments:
>   https://sourceforge.net/p/gar/code/26631/
>
> The packages should show up here soon:
>   http://buildfarm.opencsw.org/experimental.html#r_base
>
> Please have a look and let me know if everything works so I can push them to unstable.

Thanks! I am sorry it needed so many fixes. So basically every
directly linked library should be added as a dependency?

I took a quick look, and it looks good. Of course I could only look at
Solaris 10 i386, but both the 32 bit and 64 bit version looks good.

One thing that could be improved is the handling of the 32 bit and 64
archs. R has its own package system to distribute R code, and it also
supports multi-arch R packages, but the Solaris package does not
support this currently. I'll try to fix this for the next version.

Cheers,
Gabor

[...]
>
> Best regards
>
>   ? Dago
>
> >
> > Hope this is all! Sorry for the sloppy job!
> > Gabor
> >
> > On Mon, Apr 27, 2020 at 1:56 AM G?bor Cs?rdi <csardi.gabor at gmail.com> wrote:
> >>
> >> Thanks,
> >>
> >> it is like I may have made a mistake for R 4.0.0 which needs PCRE2,
> >> there is no libpcre2 package, but instead it is just pcre. I.e.
> >>
> >> -RUNTIME_DEP_PKGS_CSWr-base += CSWlibpcre1
> >> +RUNTIME_DEP_PKGS_CSWr-base += CSWpcre2
> >>
> >> is the correct change. I have no idea how I could install this...
> >>
> >> Sorry about it!
> >> Thanks,
> >> Gabor
> >>
> >> On Sun, Apr 26, 2020 at 3:32 PM Dagobert Michelsen <dam at opencsw.org> wrote:
> >>>
> >>> Hi Gabor,
> >>>
> >>> Am 26.04.2020 um 15:42 schrieb G?bor Cs?rdi <csardi.gabor at gmail.com>:
> >>>> Actually, building 4.0.0 was simple, so you might as well skip 3.6.3.
> >>>> The new patch is attached.
> >>>
> >>> Excellent, the patch applied cleanly and the rebuild is running. If everything
> >>> is fine I?ll directly push 4.0.0 to unstable!
> >>>
> >>>
> >>> Thanks a lot and best regards
> >>>
> >>>  ? Dago
> >>>
> >>>>
> >>>> Thanks,
> >>>> Gabor
> >>>>
> >>>> On Sun, Apr 26, 2020 at 1:31 PM G?bor Cs?rdi <csardi.gabor at gmail.com> wrote:
> >>>>>
> >>>>> OK, patch is attached. It has
> >>>>>
> >>>>> - a new configure option: --with-internal-tzcode The R Admin manual
> >>>>> claims that this works better than the built-in time zone support.
> >>>>> - a small patch, because the presence of utimensat() function is mis-detected
> >>>>> - added libfreetype6 as a run-time dependency. The solaris version
> >>>>> seems to be 32 bit only
> >>>>>
> >>>>> I'll try to build the new 4.0.0 version as well.
> >>>>>
> >>>>> Thanks much!
> >>>>> Gabor
> >>>>>
> >>>>> On Fri, Apr 24, 2020 at 7:18 PM Dagobert Michelsen <dam at opencsw.org> wrote:
> >>>>>>
> >>>>>> Hi Gabor,
> >>>>>>
> >>>>>> Am 24.04.2020 um 19:38 schrieb G?bor Cs?rdi <csardi.gabor at gmail.com>:
> >>>>>>> OK, in a minute, but first a quick question. Does the build server
> >>>>>>> create a minimal environment wrt dependencies?
> >>>>>>>
> >>>>>>> E.g. it turned out that to build this, I needed libfreetype_dev, but
> >>>>>>> that was not in the listed dependencies. If I miss this and do not
> >>>>>>> update the dependencies, will the build server notice?
> >>>>>>
> >>>>>> The development dependencies are sometimes listed in GAR - they should be,
> >>>>>> but it is not minimal as the build servers are statically set up.
> >>>>>> Usually a build dependency results in a runtime dependency to a
> >>>>>> coresponding shared library and that would be noticed.
> >>>>>>
> >>>>>>
> >>>>>> Best regards
> >>>>>>
> >>>>>> ? Dago
> >>>>>>
> >>>>>>>
> >>>>>>> Thanks,
> >>>>>>> Gabor
> >>>>>>>
> >>>>>>> On Fri, Apr 24, 2020 at 5:33 PM Dagobert Michelsen <dam at opencsw.org> wrote:
> >>>>>>>>
> >>>>>>>> Hi Gabor,
> >>>>>>>>
> >>>>>>>>> Am 24.04.2020 um 16:47 schrieb G?bor Cs?rdi via users <users at lists.opencsw.org>:
> >>>>>>>>>
> >>>>>>>>> Hi all, I managed to update the r_base package to 3.6.3, Jan or
> >>>>>>>>> somebody else interested in a minimal patch?
> >>>>>>>>>
> >>>>>>>>> (Sending messages from the web page does not work, btw.)
> >>>>>>>>
> >>>>>>>> Sure, just send them over :-)
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> Best regards
> >>>>>>>>
> >>>>>>>> ? Dago
> >>>>>>>>
> >>>>>>>> --
> >>>>>>>> "You don't become great by trying to be great, you become great by wanting to do something,
> >>>>>>>> and then doing it so hard that you become great in the process." - xkcd #896
> >>>>>>>>
> >>>>>>
> >>>>>> --
> >>>>>> "You don't become great by trying to be great, you become great by wanting to do something,
> >>>>>> and then doing it so hard that you become great in the process." - xkcd #896
> >>>>>>
> >>>> <r-base-4.0.0.patch>
> >>>
> >>> --
> >>> "You don't become great by trying to be great, you become great by wanting to do something,
> >>> and then doing it so hard that you become great in the process." - xkcd #896
> >>>
>
> --
> "You don't become great by trying to be great, you become great by wanting to do something,
> and then doing it so hard that you become great in the process." - xkcd #896
>

From dam at opencsw.org  Wed Apr 29 08:29:55 2020
From: dam at opencsw.org (Dagobert Michelsen)
Date: Wed, 29 Apr 2020 08:29:55 +0200
Subject: r_base 3.3.0 -> 3.6.3
In-Reply-To: <CABtg=KkP7zqy6tu2pNB1cojOL_7AntFFhVcWVw8zpQGeLmO2sw@mail.gmail.com>
References: <CABtg=Kn-aYU4i5TT5g33v18R5t7uUF44UcoB6N3NagUC+DWcGg@mail.gmail.com>
 <12B3A621-20EC-42A5-8A94-7EB809D22863@opencsw.org>
 <CABtg=KmrWq+P1NLFBHNkJE7+GhySQOVW7QL6QYAt_WBhEPw0Tg@mail.gmail.com>
 <CBBDE426-C7D7-4C10-9464-C2AAE48D7103@opencsw.org>
 <CABtg=Kkefrky4w8vYncWA597gTyLDB6Z2foFqKtBhoufEQ6Abg@mail.gmail.com>
 <CABtg=K=-Pf-twPpn0X9UCfvzQdfjaBAFcA3Hcv0h9TiLf9kd-g@mail.gmail.com>
 <BC53DFB4-04A8-40F3-BF47-E3B1CF6311E6@opencsw.org>
 <CABtg=K=u1z0e4gdgRz9DC2D_kAVWLWK6KFnpdJTnwOMTB9nPmQ@mail.gmail.com>
 <CABtg=KnVOJn5GqQCuOwBmb1gzrGj_3rjUjPeyRnEZLNAJFOMrQ@mail.gmail.com>
 <6A7F9D03-96D6-4301-A35F-91A99280CADB@opencsw.org>
 <CABtg=KkP7zqy6tu2pNB1cojOL_7AntFFhVcWVw8zpQGeLmO2sw@mail.gmail.com>
Message-ID: <007530E5-0268-4B80-A613-6AC76B5427C9@opencsw.org>

Hi Gabor,

Am 28.04.2020 um 22:27 schrieb G?bor Cs?rdi <csardi.gabor at gmail.com>:
> So basically every
> directly linked library should be added as a dependency?

Yes, otherwise the binary requiring the library won?t load and pkgutil
will install everything needed automatically this way.

> I took a quick look, and it looks good. Of course I could only look at
> Solaris 10 i386, but both the 32 bit and 64 bit version looks good.

Excellent, I?ll push 4.0.0 to unstable then. Thanks!

> One thing that could be improved is the handling of the 32 bit and 64
> archs. R has its own package system to distribute R code, and it also
> supports multi-arch R packages, but the Solaris package does not
> support this currently. I'll try to fix this for the next version.

Good idea, just let me know what adjustments are needed. Probably
something similar to the individual packages that we have in Perl
or Python?


Best regards

  ? Dago

-- 
"You don't become great by trying to be great, you become great by wanting to do something,
and then doing it so hard that you become great in the process." - xkcd #896


From csardi.gabor at gmail.com  Thu Apr 30 04:59:36 2020
From: csardi.gabor at gmail.com (=?UTF-8?B?R8OhYm9yIENzw6FyZGk=?=)
Date: Thu, 30 Apr 2020 03:59:36 +0100
Subject: Dollar in file name
Message-ID: <CABtg=KmHmYbq02DOM3qiqFD_-XMOe4VsTEZs_UAiJ1EzZJTk4g@mail.gmail.com>

Hi all,

I happen to have two files with '$' characters in their names, and
`mgar package` fails because apparently pkgmk does not handle this.

Is there a workaround? Is it possible to rename the files, and then
rename them back after installation? They are not needed during
compilation.

Thanks,
Gabor

From csardi.gabor at gmail.com  Thu Apr 30 05:24:28 2020
From: csardi.gabor at gmail.com (=?UTF-8?B?R8OhYm9yIENzw6FyZGk=?=)
Date: Thu, 30 Apr 2020 04:24:28 +0100
Subject: patch for texinfo 6.1 -> 6.7
Message-ID: <CABtg=KnpWMbUSzFTtkv2eonhjfkXme7oZAxzs3jbdwvXbkXVKQ@mail.gmail.com>

Switches to gcc, I hope that is OK.

Best,
Gabor
-------------- next part --------------
A non-text attachment was scrubbed...
Name: texinfo-6.7.patch
Type: application/octet-stream
Size: 1415 bytes
Desc: not available
URL: <http://lists.opencsw.org/pipermail/users/attachments/20200430/d0bce73a/attachment.obj>

From dam at opencsw.org  Thu Apr 30 08:40:16 2020
From: dam at opencsw.org (Dagobert Michelsen)
Date: Thu, 30 Apr 2020 08:40:16 +0200
Subject: Dollar in file name
In-Reply-To: <CABtg=KmHmYbq02DOM3qiqFD_-XMOe4VsTEZs_UAiJ1EzZJTk4g@mail.gmail.com>
References: <CABtg=KmHmYbq02DOM3qiqFD_-XMOe4VsTEZs_UAiJ1EzZJTk4g@mail.gmail.com>
Message-ID: <CD0DA1D8-7F9C-4878-BB34-E2271C9AB7C9@opencsw.org>

Hi,

Am 30.04.2020 um 04:59 schrieb G?bor Cs?rdi via users <users at lists.opencsw.org>:
> Hi all,
> 
> I happen to have two files with '$' characters in their names, and
> `mgar package` fails because apparently pkgmk does not handle this.
> 
> Is there a workaround? Is it possible to rename the files, and then
> rename them back after installation? They are not needed during
> compilation.

You can rename these during postinstall, but I would recommended to not use
files with such names. The same applies for files with spaces which also
cannot be installed with pkgmk. A solution would rename the files upfront with
some kind of escaping, then call pkgmk and either a postinstall script or
a class action script that would rename the files back. However, I would
recommend to change the software to use the files with the changes names
(e.g. _ instead of space and some other charachter instead of $).


Best regards

  ? Dago

-- 
"You don't become great by trying to be great, you become great by wanting to do something,
and then doing it so hard that you become great in the process." - xkcd #896


From csardi.gabor at gmail.com  Thu Apr 30 12:58:00 2020
From: csardi.gabor at gmail.com (=?UTF-8?B?R8OhYm9yIENzw6FyZGk=?=)
Date: Thu, 30 Apr 2020 11:58:00 +0100
Subject: Dollar in file name
In-Reply-To: <CD0DA1D8-7F9C-4878-BB34-E2271C9AB7C9@opencsw.org>
References: <CABtg=KmHmYbq02DOM3qiqFD_-XMOe4VsTEZs_UAiJ1EzZJTk4g@mail.gmail.com>
 <CD0DA1D8-7F9C-4878-BB34-E2271C9AB7C9@opencsw.org>
Message-ID: <CABtg=KnvJb4BwMzJ+-fapPPuSXynoMSFT=N47y24_roUqS=VCQ@mail.gmail.com>

On Thu, Apr 30, 2020 at 7:40 AM Dagobert Michelsen <dam at opencsw.org> wrote:
>
> Hi,
>
> Am 30.04.2020 um 04:59 schrieb G?bor Cs?rdi via users <users at lists.opencsw.org>:
> > Hi all,
> >
> > I happen to have two files with '$' characters in their names, and
> > `mgar package` fails because apparently pkgmk does not handle this.
> >
> > Is there a workaround? Is it possible to rename the files, and then
> > rename them back after installation? They are not needed during
> > compilation.
>
> You can rename these during postinstall, but I would recommended to not use
> files with such names. The same applies for files with spaces which also
> cannot be installed with pkgmk. A solution would rename the files upfront with
> some kind of escaping, then call pkgmk and either a postinstall script or
> a class action script that would rename the files back. However, I would
> recommend to change the software to use the files with the changes names
> (e.g. _ instead of space and some other charachter instead of $).

Thanks! It is unfortunately not up to me to choose the filenames, and
changing this upstream is pretty hopeless. I also cannot easily change
it in a patch, because these files are referred to in other files.

I am having a hard time finding more docs on Makefile files for the
build system, can you point me to the right place? Or show me a small
example how such renaming + renaming back would go?

Thanks again!
Gabor


[...]

From dam at opencsw.org  Thu Apr 30 14:36:18 2020
From: dam at opencsw.org (Dagobert Michelsen)
Date: Thu, 30 Apr 2020 14:36:18 +0200
Subject: Dollar in file name
In-Reply-To: <CABtg=KnvJb4BwMzJ+-fapPPuSXynoMSFT=N47y24_roUqS=VCQ@mail.gmail.com>
References: <CABtg=KmHmYbq02DOM3qiqFD_-XMOe4VsTEZs_UAiJ1EzZJTk4g@mail.gmail.com>
 <CD0DA1D8-7F9C-4878-BB34-E2271C9AB7C9@opencsw.org>
 <CABtg=KnvJb4BwMzJ+-fapPPuSXynoMSFT=N47y24_roUqS=VCQ@mail.gmail.com>
Message-ID: <D2857ACD-15FE-4E7F-93DF-7A8B3A542233@opencsw.org>

Hi Gabor,

Am 30.04.2020 um 12:58 schrieb G?bor Cs?rdi <csardi.gabor at gmail.com>:
> On Thu, Apr 30, 2020 at 7:40 AM Dagobert Michelsen <dam at opencsw.org> wrote:
>> Am 30.04.2020 um 04:59 schrieb G?bor Cs?rdi via users <users at lists.opencsw.org>:
>>> I happen to have two files with '$' characters in their names, and
>>> `mgar package` fails because apparently pkgmk does not handle this.
>>> 
>>> Is there a workaround? Is it possible to rename the files, and then
>>> rename them back after installation? They are not needed during
>>> compilation.
>> 
>> You can rename these during postinstall, but I would recommended to not use
>> files with such names. The same applies for files with spaces which also
>> cannot be installed with pkgmk. A solution would rename the files upfront with
>> some kind of escaping, then call pkgmk and either a postinstall script or
>> a class action script that would rename the files back. However, I would
>> recommend to change the software to use the files with the changes names
>> (e.g. _ instead of space and some other charachter instead of $).
> 
> Thanks! It is unfortunately not up to me to choose the filenames, and
> changing this upstream is pretty hopeless. I also cannot easily change
> it in a patch, because these files are referred to in other files.
> 
> I am having a hard time finding more docs on Makefile files for the
> build system, can you point me to the right place?

Best is to start with the maintainer docs:
  http://wiki.opencsw.org/maintainers
There is also a doc to class action scripts.
You can take a look at postinstall scripts, best by example with
something like
  dam at login [login]:/home/dam/mgar/pkg > ls -l */trunk/files/*postinstall*

If you have further troubles just drop me a note.


Best regards

  ? Dago

-- 
"You don't become great by trying to be great, you become great by wanting to do something,
and then doing it so hard that you become great in the process." - xkcd #896