[csw-maintainers] GAR v2 : preinstall step is not always executed

[Dagobert Michelsen]

Hi William,

Am 24.02.2009 um 23:48 schrieb William Bonnet:
> I am updateing my X11 libs packages in order to finally release these.
>
> I have noticed that for some package the preinstall step is not  
> executed in same case
>
> I tested it on the x11/inputproto package.
>
> If i run gmake clean && gmake package, then the pre-install target  
> is never executed. But it i run gmake clean && gmake extract &&  
> gmake install then it is executed.
>
> Is it a bug or a feature ? ;) Did i missed something or did  
> something wrong ?

Difficult. In GAR v1 you had one flow in the Makefile:
   checksum -> extract -> patch -> configure -> build -> test ->  
install -> package
With GAR v2 you have
   checksum -> extract -> patch -> configure -> build -> test ->  
install -> merge -> package
            -> extract -> patch -> configure -> build -> test ->  
install -> merge ->
            -> extract -> patch -> configure -> build -> test ->  
install -> merge ->
That means the flow is split up for each modulation and then
reunited before the package phase.

Now a pre-install would mean "run pre-install before the first
install is run". That would be easy. However, post-install as
"run after the last install is run, but before the first merge"
is somewhat difficult because invoking merge-modulation for
one modulation would trigger install-modulated for all modulations
to satisfy this condition.

Thinking again I imagine that having general pre- and post-scripts for
modulated rules outside the modulation is not really useful besides the
edge-cases pre-extract and post-merge. I suggest changing the meaning
of post-install to be what is currently post-install-modulated. During
the transition warnings like this could be issued:

   WARNING: 'pre-install-modulated' was called. The behaviour in mGAR v2
   has changed. Please use 'pre-install' instead.

I don't know how effectively modulations are used right now.
Is this change straight forward or do I talk not-understandable
stuff here? Thoughts?


Best regards

   -- Dago
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.opencsw.org/pipermail/maintainers/attachments/20090301/9620ab5e/attachment.html>