[csw-maintainers] Is there a reason not to fix uninitialized $REVISION warning

Maciej (Matchek) Bliziński maciej at opencsw.org
Mon Nov 7 10:40:58 CET 2011


2011/11/7 Бондаренко Андрей Витальевич <bondarenko.av at mmk.ru>:
> I'm new to OpenCSW and GAR. Can anybody tell me If there is a reason
> behind keeping "Use of uninitialized value $REVISION in sprint ..." warning
> in mkpackage?
>
> I've cloned GAR into a private mercurial repository to be able track changes
> not accepted in trunk. Mercurial does not expand keywords by default, so
> I get warning about uninitialized REVISION on each build. I find it quite
> annoying and fixed it in my branch (see attached patch), but I it looks like
> the warning is left intentionally. It is well known and mkpackage contains
> comment about the warning in the code. Can somebody explain me why?

I left the comment there in the hope that Dago who reads the commit
log on the devel list would see it and fix it.  But it did't happen,
so the warning remained.

I committed your patch, thanks!

http://sourceforge.net/apps/trac/gar/changeset/16119

Maciej


More information about the maintainers mailing list