[csw-maintainers] [csw-pkgsubmissions] newpkgs puppet, puppetmaster

[Dagobert Michelsen]

Hi Ben,

(moving to maintainers@)

Am 17.05.2011 um 18:47 schrieb Ben Walton:
> Excerpts from Philip Brown's message of Tue May 17 12:40:46 -0400 2011:
> 
>> yes, see http://www.opencsw.org/packages/puppet/
>> 
>> Since people can still trim off the @UNCOMMITTED and get something
>> useful, I deemed it non-fatal.
> 
> I agree it's non-fatal, I was just clarifying.

I think it should be fatal: not because the error is that big, but because
1) it can result in privately build, non-repeatable package builds
2) it breaks browsing of the repository
3) it is really easy to fix

>> Reguardless of what triggered it, I think that the mgar [re]package
>> code, should refuse to continue if it attempts to package something
>> with OPENCSW_REPOSITORY=.*UNCOMMITTED
> 
> Actually, this should be a check added to checkpkg.  The [re]package
> target in mgar shouldn't care about this.

I thought submitpkg already had a trigger in it refusing to submit
uncommitted packages?


Best regards

  -- Dago